Skip to content

Revert all the FS-related changes. - #8970

Merged
Eric Snow (ericsnowcurrently) merged 8 commits into
microsoft:masterfrom
ericsnowcurrently:revert-fs-changes
Dec 10, 2019
Merged

Eric Snow (ericsnowcurrently) merged 8 commits into
microsoft:masterfrom
ericsnowcurrently:revert-fs-changes

Conversation

@ericsnowcurrently

Copy link
Copy Markdown

(for #8890)

We continue to have problems due to the FS-related changes. So I'm reverting them until we can get all that sorted out.

@codecov-io

Codecov (codecov-io) commented Dec 9, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #8970 into master will decrease coverage by 0.26%.
The diff coverage is 38.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8970      +/-   ##
==========================================
- Coverage   58.17%   57.91%   -0.27%     
==========================================
  Files         529      530       +1     
  Lines       27729    27638      -91     
  Branches     4178     4182       +4     
==========================================
- Hits        16132    16006     -126     
- Misses      10705    10739      +34     
- Partials      892      893       +1
Impacted Files Coverage Δ
src/client/sourceMapSupport.ts 81.25% <ø> (ø) ⬆️
src/client/common/platform/types.ts 100% <ø> (ø) ⬆️
...rc/client/debugger/debugAdapter/serviceRegistry.ts 0% <0%> (ø) ⬆️
.../datascience/interactive-common/interactiveBase.ts 18.67% <0%> (ø) ⬆️
src/client/providers/renameProvider.ts 22.72% <0%> (-0.68%) ⬇️
...rpreter/locators/services/baseVirtualEnvService.ts 28.3% <0%> (ø) ⬆️
src/client/providers/jediProxy.ts 23.42% <100%> (+0.05%) ⬆️
src/client/workspaceSymbols/provider.ts 93.33% <100%> (ø) ⬆️
src/client/common/net/fileDownloader.ts 100% <100%> (ø) ⬆️
src/client/common/variables/environment.ts 92.3% <100%> (-0.1%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb59d3...f01692d. Read the comment docs.

@ericsnowcurrently

Copy link
Copy Markdown
Author

The failing smoke test does not appear to be related. I've opened a separate issue about that failure: #8984.

@ericsnowcurrently
Eric Snow (ericsnowcurrently) merged commit 636e579 into microsoft:master Dec 10, 2019
@ericsnowcurrently
Eric Snow (ericsnowcurrently) deleted the revert-fs-changes branch December 10, 2019 18:19
@ericsnowcurrently
Eric Snow (ericsnowcurrently) restored the revert-fs-changes branch December 10, 2019 18:19
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 17, 2019
@ericsnowcurrently
Eric Snow (ericsnowcurrently) deleted the revert-fs-changes branch April 8, 2020 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants