Repository navigation
Fixes to FileSystem code to use bitwise operations - #8966
Merged
Don Jayamanne (DonJayamanne) merged 5 commits intoDec 9, 2019
Merged
Conversation
Rich Chiodo (rchiodo)
approved these changes
Dec 9, 2019
Karthik Nadig (karthiknadig)
approved these changes
Dec 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #8966 +/- ##
=========================================
+ Coverage 57.87% 58.17% +0.3%
=========================================
Files 529 529
Lines 27727 27729 +2
Branches 4172 4178 +6
=========================================
+ Hits 16046 16132 +86
+ Misses 10784 10699 -85
- Partials 897 898 +1
Continue to review full report at Codecov.
|
Eric Snow (ericsnowcurrently)
added a commit
to ericsnowcurrently/vscode-python
that referenced
this pull request
Dec 9, 2019
Eric Snow (ericsnowcurrently)
pushed a commit
that referenced
this pull request
Dec 10, 2019
(for #8890) The plan is to un-revert this stuff bit-by-bit. * Revert "Fixes to FileSystem code to use bitwise operations (#8966)" This reverts commit acb59d3. * Revert "Make sure IFileSystem is registered in DI during tests. (#8902)" This reverts commit dabd87f. * Revert "Remove IFileSystemUtils from IOC container (#8898)" This reverts commit 8ab93d7. * Revert "Skip a few more tests. (#8830)" This reverts commit d197557. * Revert "Skip problematic tests. (#8810)" This reverts commit c5f7766. * Revert "Use new VS Code filesystem API. (#8307)" This reverts commit 7cbd1c2. * Revert "Update the code base to use IFileSystem instead of fs and fs-extra. (#7915)" This reverts commit a23761d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8890