Repository navigation
Make sure IFileSystem is registered in DI during tests. - #8902
Merged
Eric Snow (ericsnowcurrently) merged 3 commits intoDec 5, 2019
Merged
Eric Snow (ericsnowcurrently) merged 3 commits into
Eric Snow (ericsnowcurrently) merged 3 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8902 +/- ##
==========================================
+ Coverage 57.95% 58.16% +0.21%
==========================================
Files 527 529 +2
Lines 27532 27634 +102
Branches 4146 4162 +16
==========================================
+ Hits 15955 16073 +118
+ Misses 10700 10671 -29
- Partials 877 890 +13
Continue to review full report at Codecov.
|
Eric Snow (ericsnowcurrently)
requested a review
from Kim-Adeline Miguel (kimadeline)
December 4, 2019 21:50
Kim-Adeline Miguel (kimadeline)
approved these changes
Dec 4, 2019
3 tasks
Eric Snow (ericsnowcurrently)
added a commit
to ericsnowcurrently/vscode-python
that referenced
this pull request
Dec 9, 2019
…osoft#8902)" This reverts commit dabd87f.
Eric Snow (ericsnowcurrently)
pushed a commit
that referenced
this pull request
Dec 10, 2019
(for #8890) The plan is to un-revert this stuff bit-by-bit. * Revert "Fixes to FileSystem code to use bitwise operations (#8966)" This reverts commit acb59d3. * Revert "Make sure IFileSystem is registered in DI during tests. (#8902)" This reverts commit dabd87f. * Revert "Remove IFileSystemUtils from IOC container (#8898)" This reverts commit 8ab93d7. * Revert "Skip a few more tests. (#8830)" This reverts commit d197557. * Revert "Skip problematic tests. (#8810)" This reverts commit c5f7766. * Revert "Use new VS Code filesystem API. (#8307)" This reverts commit 7cbd1c2. * Revert "Update the code base to use IFileSystem instead of fs and fs-extra. (#7915)" This reverts commit a23761d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #8882)
[ ] Has a news entry file (remember to thank yourself!)[ ] Appropriate comments and documentation strings in the code[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Unit tests & system/integration tests are added/updated[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.