Skip to content

Remove IFileSystemUtils from IoC container #8898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Don Jayamanne (DonJayamanne) merged 1 commit into from
Dec 5, 2019
Merged

Remove IFileSystemUtils from IoC container #8898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/client/common/platform/fileSystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,6 @@ export class RawFileSystem implements IRawFileSystem {
}

// High-level filesystem operations used by the extension.
@injectable()
export class FileSystemUtils implements IFileSystemUtils {
constructor(
public readonly raw: IRawFileSystem,
Expand Down
5 changes: 2 additions & 3 deletions src/client/common/platform/serviceRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@
'use strict';

import { IServiceManager } from '../../ioc/types';
import { FileSystem, FileSystemUtils } from './fileSystem';
import { FileSystem } from './fileSystem';
import { PlatformService } from './platformService';
import { RegistryImplementation } from './registry';
import { IFileSystem, IFileSystemUtils, IPlatformService, IRegistry } from './types';
import { IFileSystem, IPlatformService, IRegistry } from './types';

export function registerTypes(serviceManager: IServiceManager) {
serviceManager.addSingleton<IPlatformService>(IPlatformService, PlatformService);
serviceManager.addSingleton<IFileSystem>(IFileSystem, FileSystem);
serviceManager.addSingletonInstance<IFileSystemUtils>(IFileSystemUtils, FileSystemUtils.withDefaults());
serviceManager.addSingleton<IRegistry>(IRegistry, RegistryImplementation);
}
1 change: 0 additions & 1 deletion src/client/common/platform/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ export interface IRawFileSystem {
}

// High-level filesystem operations used by the extension.
export const IFileSystemUtils = Symbol('IFileSystemUtils');
export interface IFileSystemUtils {
readonly raw: IRawFileSystem;
readonly paths: IFileSystemPaths;
Expand Down