Repository navigation
Remove IFileSystemUtils from IoC container - #8898
Merged
Don Jayamanne (DonJayamanne) merged 1 commit intoDec 5, 2019
Merged
Don Jayamanne (DonJayamanne) merged 1 commit into
Don Jayamanne (DonJayamanne) merged 1 commit into
Conversation
Don Jayamanne (DonJayamanne)
requested review from
Eric Snow (ericsnowcurrently) and
Karthik Nadig (karthiknadig)
December 4, 2019 17:35
Codecov Report
@@ Coverage Diff @@
## master #8898 +/- ##
==========================================
- Coverage 57.95% 57.94% -0.01%
==========================================
Files 527 527
Lines 27532 27530 -2
Branches 4146 4146
==========================================
- Hits 15955 15953 -2
Misses 10700 10700
Partials 877 877
Continue to review full report at Codecov.
|
Don Jayamanne (DonJayamanne)
changed the title
Eric Snow (ericsnowcurrently)
approved these changes
Dec 5, 2019
Eric Snow (ericsnowcurrently)
left a comment
Eric Snow (ericsnowcurrently)
left a comment
There was a problem hiding this comment.
Thanks for doing this.
|
FWIW, My eventual plan was to get rid of IFileSystem (and move everything to IFileSystemUtils). However, until then there certainly is no reason to have IFileSystemUtils in the IOC container. :) |
Eric Snow (ericsnowcurrently)
added a commit
to ericsnowcurrently/vscode-python
that referenced
this pull request
Dec 9, 2019
This reverts commit 8ab93d7.
Eric Snow (ericsnowcurrently)
pushed a commit
that referenced
this pull request
Dec 10, 2019
(for #8890) The plan is to un-revert this stuff bit-by-bit. * Revert "Fixes to FileSystem code to use bitwise operations (#8966)" This reverts commit acb59d3. * Revert "Make sure IFileSystem is registered in DI during tests. (#8902)" This reverts commit dabd87f. * Revert "Remove IFileSystemUtils from IOC container (#8898)" This reverts commit 8ab93d7. * Revert "Skip a few more tests. (#8830)" This reverts commit d197557. * Revert "Skip problematic tests. (#8810)" This reverts commit c5f7766. * Revert "Use new VS Code filesystem API. (#8307)" This reverts commit 7cbd1c2. * Revert "Update the code base to use IFileSystem instead of fs and fs-extra. (#7915)" This reverts commit a23761d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8307
Removing IFileSystemUtils from the IOC container as this then means we have 2 ways of accessing FIleSystem related stuff (IFileSystem and IFileSystemUtils).
From what I can tell FileSystemUtils is used purely in fileSystem class and doesn't need to be exposed outside. Hence we shouldn't even need the IFileSystemUtils interface, as the class is sufficient. Though i'm not removing that here as thats a point of preference. There are other similar interfaces as well. Not sure why they exist instead of using pure classes.
This PR ensures we continue to have one way for FS stuff and theres no confusion.