Repository navigation
Add "Run All" CodeLens for parametrized tests - #8682
Closed
Philipp Loose (phloose) wants to merge 3 commits into
Closed
Philipp Loose (phloose) wants to merge 3 commits into
Philipp Loose (phloose) wants to merge 3 commits into
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #8682 +/- ##
==========================================
- Coverage 59.17% 59.16% -0.02%
==========================================
Files 521 521
Lines 23981 23987 +6
Branches 3874 3875 +1
==========================================
+ Hits 14190 14191 +1
- Misses 8874 8879 +5
Partials 917 917
Continue to review full report at Codecov.
|
Karthik Nadig (karthiknadig)
requested review from
Don Jayamanne (DonJayamanne) and
Kartik Raj (karrtikr)
November 22, 2019 02:52
Author
|
Closing in favor of #8757 |
Philipp Loose (phloose)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5608.
This pull request aims to add a third code lens for running all parametrized tests that belong to a test function/method. Unlike suggested in the mentioned issue i found it more practical to not add the "Run All" option in the dropdown/picker. If one wants to run all parametrized tests that belong to a specific test he or she needs to only click this codelens and not click on run/debug test and then select that option from the dropdown/picker. So the usecase is more that one is able to select specific test with the first two codelenses that lets you select which specific test you want to run or debug, and to test if all of those parametrized tests run click on "Run All".
Has sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)