Skip to content

Track if jupyter is not installed in current env - #8370

Merged
Don Jayamanne (DonJayamanne) merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue8369
Nov 4, 2019
Merged

Track if jupyter is not installed in current env#8370
Don Jayamanne (DonJayamanne) merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue8369

Conversation

@DonJayamanne

@DonJayamanne Don Jayamanne (DonJayamanne) commented Nov 4, 2019

Copy link
Copy Markdown

For #8369

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Nov 4, 2019
@codecov-io

Codecov (codecov-io) commented Nov 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8370 into master will decrease coverage by <.01%.
The diff coverage is 65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8370      +/-   ##
==========================================
- Coverage   59.39%   59.38%   -0.01%     
==========================================
  Files         508      508              
  Lines       23236    23247      +11     
  Branches     3750     3754       +4     
==========================================
+ Hits        13800    13806       +6     
- Misses       8540     8545       +5     
  Partials      896      896
Impacted Files Coverage Δ
src/client/datascience/constants.ts 100% <100%> (ø) ⬆️
src/client/telemetry/index.ts 86.13% <100%> (ø) ⬆️
...client/datascience/jupyter/jupyterCommandFinder.ts 73.62% <100%> (+1.53%) ⬆️
...atascience/interactive-window/interactiveWindow.ts 22.22% <12.5%> (-1.7%) ⬇️
src/client/terminals/codeExecution/helper.ts 21.27% <0%> (-0.73%) ⬇️
src/client/testing/navigation/symbolProvider.ts 93.1% <0%> (-0.65%) ⬇️
src/client/common/utils/localize.ts 93.99% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b202ad2...a56614e. Read the comment docs.

rchiodo
Rich Chiodo (rchiodo) previously approved these changes Nov 4, 2019
View reviewed changes

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

rchiodo
Rich Chiodo (rchiodo) reviewed Nov 4, 2019
View reviewed changes
Comment thread src/client/datascience/jupyter/jupyterCommandFinder.ts Outdated
rchiodo
Rich Chiodo (rchiodo) requested changes Nov 4, 2019
View reviewed changes

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

rchiodo
Rich Chiodo (rchiodo) approved these changes Nov 4, 2019
View reviewed changes

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne

Don Jayamanne (DonJayamanne) commented Nov 4, 2019

Copy link
Copy Markdown
Author

CI fell over.

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 700bc48 into microsoft:master Nov 4, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff Ian Huff (IanMatthewHuff) IanMatthewHuff approved these changes
@rchiodo Rich Chiodo (rchiodo) rchiodo approved these changes
@DavidKutu David Kutugata (DavidKutu) Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo