Skip to content

Moved the toolbar to render right below inputs. - #8336

Merged
David Kutugata (DavidKutu) merged 1 commit into
masterfrom
davidkutu/toolbar_takes_space
Nov 1, 2019
Merged

David Kutugata (DavidKutu) merged 1 commit into
masterfrom
davidkutu/toolbar_takes_space

Conversation

@DavidKutu

Copy link
Copy Markdown

This saves a bit of space with single line block of code.

For #8052

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

This saves a bit of space with single line block of code.
@DavidKutu David Kutugata (DavidKutu) added the no-changelog No news entry required label Nov 1, 2019
@codecov-io

Codecov (codecov-io) commented Nov 1, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #8336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8336   +/-   ##
=======================================
  Coverage   59.24%   59.24%           
=======================================
  Files         508      508           
  Lines       23227    23227           
  Branches     3746     3746           
=======================================
  Hits        13761    13761           
  Misses       8573     8573           
  Partials      893      893

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072ccea...d02c66f. Read the comment docs.

@DavidKutu
David Kutugata (DavidKutu) merged commit c50c778 into master Nov 1, 2019
@DavidKutu
David Kutugata (DavidKutu) deleted the davidkutu/toolbar_takes_space branch November 1, 2019 20:07
@DavidKutu
David Kutugata (DavidKutu) restored the davidkutu/toolbar_takes_space branch November 1, 2019 20:07
@DavidKutu
David Kutugata (DavidKutu) deleted the davidkutu/toolbar_takes_space branch November 1, 2019 20:08
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants