Repository navigation
Add unit tests for common/process/pythonProcess.ts - #8329
Merged
Kim-Adeline Miguel (kimadeline) merged 8 commits intoNov 4, 2019
Merged
Kim-Adeline Miguel (kimadeline) merged 8 commits into
Kim-Adeline Miguel (kimadeline) merged 8 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8329 +/- ##
==========================================
+ Coverage 58.66% 59.23% +0.57%
==========================================
Files 505 508 +3
Lines 22778 23236 +458
Branches 3740 3750 +10
==========================================
+ Hits 13363 13765 +402
- Misses 8522 8577 +55
- Partials 893 894 +1
Continue to review full report at Codecov.
|
…e/vscode-python into 6065-unit-tests-python-process
Kim-Adeline Miguel (kimadeline)
marked this pull request as ready for review
November 1, 2019 22:28
Kim-Adeline Miguel (kimadeline)
requested review from
Eric Snow (ericsnowcurrently) and
Karthik Nadig (karthiknadig)
November 1, 2019 22:28
Karthik Nadig (karthiknadig)
approved these changes
Nov 2, 2019
Karthik Nadig (karthiknadig)
left a comment
Karthik Nadig (karthiknadig)
left a comment
Member
There was a problem hiding this comment.
For this check we are only testing one of the branches. Given string manipulation here I recommend adding a test for both the branches. This is non-blocking comment, i will leave it to up to you if this is needed.
Kim-Adeline Miguel (kimadeline)
deleted the
6065-unit-tests-python-process
branch
November 4, 2019 17:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #6065 (needs to be merged before the conda work in #8259 where I will add more tests to
pythonProcess.ts)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)