Repository navigation
Cache the promise returned by the command finder - #8317
Merged
Don Jayamanne (DonJayamanne) merged 2 commits intoOct 31, 2019
Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
Don Jayamanne (DonJayamanne) merged 2 commits into
Conversation
Don Jayamanne (DonJayamanne)
requested review from
David Kutugata (DavidKutu),
Ian Huff (IanMatthewHuff) and
Rich Chiodo (rchiodo)
October 31, 2019 17:49
Codecov Report
@@ Coverage Diff @@
## master #8317 +/- ##
==========================================
- Coverage 59.33% 59.31% -0.03%
==========================================
Files 504 504
Lines 23096 23103 +7
Branches 3737 3740 +3
==========================================
- Hits 13704 13703 -1
- Misses 8500 8507 +7
- Partials 892 893 +1
Continue to review full report at Codecov.
|
David Kutugata (DavidKutu)
approved these changes
Oct 31, 2019
Rich Chiodo (rchiodo)
approved these changes
Oct 31, 2019
Author
|
Flaky CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7242 (there will be others)
As everything is async, if we have two executions of the method
findBestCommand, they'll both spin off the finder. This ensures that we always find once and if one is in progress, then we use that same task.This will hopefully save additional CPU/resource usage (specially on windows).