Repository navigation
Adds logging support for python debug adapter - #8272
Merged
Karthik Nadig (karthiknadig) merged 8 commits intoOct 31, 2019
Merged
Conversation
Karthik Nadig (karthiknadig)
requested a review
from Kim-Adeline Miguel (kimadeline)
October 29, 2019 01:57
Codecov Report
@@ Coverage Diff @@
## master #8272 +/- ##
==========================================
+ Coverage 59.33% 59.38% +0.05%
==========================================
Files 504 505 +1
Lines 23096 23126 +30
Branches 3737 3740 +3
==========================================
+ Hits 13704 13734 +30
Misses 8500 8500
Partials 892 892
Continue to review full report at Codecov.
|
Member
Author
|
Don Jayamanne (@DonJayamanne) I need some advise on testing |
Karthik Nadig (karthiknadig)
force-pushed
the
dalogging
branch
2 times, most recently
from
October 30, 2019 05:14
e7e6b80 to
4942ecb
Compare
Karthik Nadig (karthiknadig)
force-pushed
the
dalogging
branch
from
October 30, 2019 16:29
4942ecb to
273654d
Compare
Karthik Nadig (karthiknadig)
marked this pull request as ready for review
October 30, 2019 18:50
Kim-Adeline Miguel (kimadeline)
approved these changes
Oct 31, 2019
Kim-Adeline Miguel (kimadeline)
left a comment
Kim-Adeline Miguel (kimadeline)
left a comment
There was a problem hiding this comment.
Some typescript suggestions but other than it looks good to me 👍
Karthik Nadig (karthiknadig)
force-pushed
the
dalogging
branch
from
October 31, 2019 19:10
c7ed650 to
e27cde8
Compare
Karthik Nadig (karthiknadig)
force-pushed
the
dalogging
branch
from
October 31, 2019 19:51
e27cde8 to
75e4b23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8106
Kim-Adeline Miguel (@kimadeline) I need some advise on testing the logger.