Repository navigation
Skip tests generated by plugins (like pep8) for discovery command. - #8242
Merged
Eric Snow (ericsnowcurrently) merged 3 commits intoNov 6, 2019
Merged
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #8242 +/- ##
==========================================
+ Coverage 59.04% 59.37% +0.32%
==========================================
Files 509 509
Lines 23299 23299
Branches 3758 3763 +5
==========================================
+ Hits 13758 13833 +75
+ Misses 8642 8567 -75
Partials 899 899
Continue to review full report at Codecov.
|
Pavel Zaikin (zztalker)
force-pushed
the
pytest-pep8
branch
2 times, most recently
from
October 28, 2019 02:30
f74433a to
a40d34b
Compare
Karthik Nadig (karthiknadig)
requested review from
Eric Snow (ericsnowcurrently) and
Karthik Nadig (karthiknadig)
November 5, 2019 03:57
Karthik Nadig (karthiknadig)
approved these changes
Nov 5, 2019
Member
|
The changes look good, might need a rebase to master to get around the test failures. |
Eric Snow (ericsnowcurrently)
approved these changes
Nov 5, 2019
Eric Snow (ericsnowcurrently)
left a comment
Eric Snow (ericsnowcurrently)
left a comment
There was a problem hiding this comment.
LGTM (with a mild caution)
Update upstream
To do not fail on discovery command and do not track their results.
Pavel Zaikin (zztalker)
force-pushed
the
pytest-pep8
branch
from
November 6, 2019 02:33
a40d34b to
2f776cd
Compare
|
FWIW, I am fairly sure that the old code (parsing the pytest CLI output) used to ignore plugin-generated nodes. If it matters then we can investigate in #8425. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do not fail on discovery command and do not track their results.
For #7287
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)