Skip to content

Fix name of launch option in docs - #8113

Merged
Kim-Adeline Miguel (kimadeline) merged 1 commit into
microsoft:masterfrom
ILikeToHelp:rename-launch-extension
Oct 28, 2019
Merged

Fix name of launch option in docs#8113
Kim-Adeline Miguel (kimadeline) merged 1 commit into
microsoft:masterfrom
ILikeToHelp:rename-launch-extension

Conversation

@ILikeToHelp

@ILikeToHelp ILikeToHelp commented Oct 19, 2019 •
edited
Loading

Copy link
Copy Markdown

This launch option was renamed to "Extenstion" in be2ae45.

Documentation change only. So I've deleted the checklist.

Please could you add "skip news" label?

@ILikeToHelp
Fix name of launch option in docs
2aa36f1 
This launch option was renamed to "Extenstion" in be2ae45.
@codecov-io

Codecov (codecov-io) commented Oct 19, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8113 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8113      +/-   ##
==========================================
+ Coverage   58.91%   59.22%   +0.31%     
==========================================
  Files         498      498              
  Lines       22427    22427              
  Branches     3602     3607       +5     
==========================================
+ Hits        13212    13283      +71     
+ Misses       8380     8309      -71     
  Partials      835      835
Impacted Files Coverage Δ
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 89.65% <0%> (+13.79%) ⬆️
src/client/api.ts 92.85% <0%> (+14.28%) ⬆️
src/client/common/utils/icons.ts 100% <0%> (+16.66%) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (+25%) ⬆️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (+33.33%) ⬆️
src/client/testing/codeLenses/main.ts 77.77% <0%> (+33.33%) ⬆️
src/client/testing/serviceRegistry.ts 95.49% <0%> (+46.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b52e6...2aa36f1. Read the comment docs.

@kimadeline Kim-Adeline Miguel (kimadeline) added the no-changelog No news entry required label Oct 21, 2019
@kimadeline

Kim-Adeline Miguel (kimadeline) commented Oct 21, 2019 •
edited
Loading

Copy link
Copy Markdown

Thank you for your contribution @HackingAndJiuJItsu 👍 Let me know if you want to add an issue in order to thank yourself. If not, I'll merge your PR.

@kimadeline
Kim-Adeline Miguel (kimadeline) merged commit e005d5f into microsoft:master Oct 28, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kimadeline Kim-Adeline Miguel (kimadeline) kimadeline approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@ILikeToHelp @codecov-io @kimadeline