Skip to content

Running a unittest file executing only the first test - #7783

Merged
Eric Snow (ericsnowcurrently) merged 6 commits into
microsoft:masterfrom
kondratyev-nv:master
Nov 6, 2019
Merged

Running a unittest file executing only the first test#7783
Eric Snow (ericsnowcurrently) merged 6 commits into
microsoft:masterfrom
kondratyev-nv:master

Conversation

@kondratyev-nv

@kondratyev-nv N Kondratyev (kondratyev-nv) commented Oct 5, 2019

Copy link
Copy Markdown

For #4567

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io

Codecov (codecov-io) commented Oct 5, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7783 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7783      +/-   ##
==========================================
+ Coverage   59.33%   59.33%   +<.01%     
==========================================
  Files         505      505              
  Lines       23147    23148       +1     
  Branches     3745     3745              
==========================================
+ Hits        13734    13735       +1     
  Misses       8520     8520              
  Partials      893      893
Impacted Files Coverage Δ
.../client/testing/unittest/services/parserService.ts 95.23% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e7bce4...2c29247. Read the comment docs.

@kondratyev-nv N Kondratyev (kondratyev-nv) mentioned this pull request Oct 5, 2019
Closed
This was referenced Oct 8, 2019
Closed
Closed
@kondratyev-nv

N Kondratyev (kondratyev-nv) commented Oct 14, 2019

Copy link
Copy Markdown
Author

Kim-Adeline Miguel (@kimadeline) Eric Snow (@ericsnowcurrently) Just a kindly reminder :) Are there any chances for this PR to be reviewed?

@kimadeline

Kim-Adeline Miguel (kimadeline) commented Oct 15, 2019

Copy link
Copy Markdown

Hi N Kondratyev (@kondratyev-nv) , thank you for your PR! We'll get to it as soon as we can.

ericsnowcurrently
Eric Snow (ericsnowcurrently) approved these changes Nov 6, 2019
View reviewed changes

@ericsnowcurrently Eric Snow (ericsnowcurrently) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm going to run a full CI pass on this PR before merging.

@ericsnowcurrently

Eric Snow (ericsnowcurrently) commented Nov 6, 2019

Copy link
Copy Markdown

CI results look fine.

@ericsnowcurrently
Eric Snow (ericsnowcurrently) merged commit 83d0cc6 into microsoft:master Nov 6, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ericsnowcurrently Eric Snow (ericsnowcurrently) ericsnowcurrently approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kondratyev-nv @codecov-io @kimadeline @ericsnowcurrently