Skip to content

Attempt to use uri of active text editor document to determine virtual env to use with terminal - #7534

Merged
Kim-Adeline Miguel (kimadeline) merged 4 commits into
microsoft:masterfrom
SteelPhase:issue-6282
Sep 27, 2019
Merged

Attempt to use uri of active text editor document to determine virtual env to use with terminal#7534
Kim-Adeline Miguel (kimadeline) merged 4 commits into
microsoft:masterfrom
SteelPhase:issue-6282

Conversation

@SteelPhase

@SteelPhase SteelPhase (SteelPhase) commented Sep 21, 2019

Copy link
Copy Markdown

For #6282

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io

Codecov (codecov-io) commented Sep 21, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7534 into master will decrease coverage by 0.16%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7534      +/-   ##
==========================================
- Coverage   58.85%   58.68%   -0.17%     
==========================================
  Files         492      493       +1     
  Lines       21823    21997     +174     
  Branches     3501     3533      +32     
==========================================
+ Hits        12843    12909      +66     
- Misses       8179     8279     +100     
- Partials      801      809       +8
Impacted Files Coverage Δ
src/client/terminals/activation.ts 78.78% <33.33%> (-0.53%) ⬇️
...active-common/intellisense/intellisenseDocument.ts 37.55% <0%> (-19.9%) ⬇️
src/client/common/application/extensions.ts 50% <0%> (-10%) ⬇️
src/client/debugger/extension/adapter/factory.ts 91.66% <0%> (-5.48%) ⬇️
...t/common/insidersBuild/insidersExtensionService.ts 96.29% <0%> (-3.71%) ⬇️
...ent/datascience/jupyter/jupyterExecutionFactory.ts 72.09% <0%> (-3.52%) ⬇️
...ve-common/intellisense/baseIntellisenseProvider.ts 26.94% <0%> (-1.36%) ⬇️
src/client/datascience/gather/gather.ts 67.92% <0%> (-1.17%) ⬇️
...on/terminal/environmentActivationProviders/bash.ts 88.88% <0%> (-1.12%) ⬇️
...ence/interactive-common/intellisense/conversion.ts 12.5% <0%> (-0.71%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dec031...e5f4592. Read the comment docs.

kimadeline
Kim-Adeline Miguel (kimadeline) approved these changes Sep 27, 2019
View reviewed changes

@kimadeline Kim-Adeline Miguel (kimadeline) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello SteelPhase (@SteelPhase) 👋 Thank you for your contribution!

You are welcome to @ yourself in the news file, and I'll merge your PR afterwards.

Thanks again!

@SteelPhase

SteelPhase (SteelPhase) commented Sep 27, 2019

Copy link
Copy Markdown
Author

I followed the VSCode Release notes format. let me know if that's alright Kim-Adeline Miguel (@kimadeline)

@kimadeline

Kim-Adeline Miguel (kimadeline) commented Sep 27, 2019 •
edited
Loading

Copy link
Copy Markdown

Sorry I should have mentioned that earlier, could you update it so that it's Message (thanks [yourself](url)).? Here's an example from our changelog:

image

Don't worry about the list item number and appending the issue number, it's done by our news parsing script.

Thanks again!

@SteelPhase

SteelPhase (SteelPhase) commented Sep 27, 2019

Copy link
Copy Markdown
Author

Thanks, I was trying to find an example but didn't notice any.

@kimadeline
Kim-Adeline Miguel (kimadeline) merged commit e54034c into microsoft:master Sep 27, 2019
Closed
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kimadeline Kim-Adeline Miguel (kimadeline) kimadeline approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SteelPhase @codecov-io @kimadeline