Skip to content

Add extra items to the path in order to fix miniconda env listing. #6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich Chiodo (rchiodo) merged 2 commits into from
Aug 5, 2019
Merged

Add extra items to the path in order to fix miniconda env listing. #6854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5551247
Add extra items to the path in order to fix miniconda env listing.
rchiodo Aug 5, 2019
3408cae
Add some more logging
rchiodo Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/6802.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix miniconda environments to work.
61 changes: 33 additions & 28 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 14 additions & 1 deletion src/client/interpreter/locators/services/condaService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,21 @@ export class CondaService implements ICondaService {
try {
const condaFile = await this.getCondaFile();
const processService = await this.processServiceFactory.create();
const envInfo = await processService.exec(condaFile, ['env', 'list']).then(output => output.stdout);
let envInfo = await processService.exec(condaFile, ['env', 'list']).then(output => output.stdout);
traceVerbose(`Conda Env List ${envInfo}}`);
if (!envInfo) {
traceVerbose('Conda env list failure, attempting path additions.');
// Try adding different folders to the path. Miniconda fails to run
// without them.
const baseFolder = path.dirname(path.dirname(condaFile));

@DonJayamanne Don Jayamanne (DonJayamanne) Aug 5, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can we add some logging using traceVerbose to log the new path value with some more comments.
This way we know it is going down this route, useful when troubleshooting...

@rchiodo Rich Chiodo (rchiodo) Aug 5, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure no problem.

const binFolder = path.join(baseFolder, 'bin');
const condaBinFolder = path.join(baseFolder, 'condabin');
const libaryBinFolder = path.join(baseFolder, 'library', 'bin');
const newEnv = process.env;
newEnv.PATH = `${binFolder};${condaBinFolder};${libaryBinFolder};${newEnv.PATH}`;
traceVerbose(`Attempting new path for conda env list: ${newEnv.PATH}`);
envInfo = await processService.exec(condaFile, ['env', 'list'], { env: newEnv }).then(output => output.stdout);
}
const environments = this.condaHelper.parseCondaEnvironmentNames(envInfo);
await globalPersistence.updateValue({ data: environments });
return environments;
Expand Down