Repository navigation
Fix exception reported in #447 - #536
Conversation
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 56.4% 56.25% -0.16%
==========================================
Files 212 212
Lines 10018 9978 -40
Branches 1762 1754 -8
==========================================
- Hits 5651 5613 -38
+ Misses 4362 4360 -2
Partials 5 5
Continue to review full report at Codecov.
|
Brett Cannon (brettcannon)
left a comment
Brett Cannon (brettcannon)
left a comment
There was a problem hiding this comment.
I asked to have the description of the tests fleshed out, but I trust you to do it properly so I'm approving ahead of time. 😉
| assert.equal(tokens.length, 0); | ||
| }); | ||
| test('Strings', async () => { | ||
| test('Strings 1', async () => { |
There was a problem hiding this comment.
Would it be possible to have a more descriptive string from the test? For example, I don't know how this is different from 'Strings 2' so I don't what I need to make sure not to change in the test so I don't break what it's meant to be testing.
There was a problem hiding this comment.
I'll try :-) have hard time coming up with names...
There was a problem hiding this comment.
I mean it can be rather wordy since it is a test. Basically come up with a sentence to explain to me why you wrote the test and make that the test name.
|
This most probably addressed by #536 coming with the next update. |
2 participants
Incorrect use of indexer on non-array
Added some more tests
Closes #447, #423