Repository navigation
Fix progress reporting for the new LS - #4620
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 3 commits intoMar 5, 2019
Merged
Conversation
added 3 commits
March 2, 2019 09:51
This reverts commit ac9b5f1.
Codecov Report
@@ Coverage Diff @@
## master #4620 +/- ##
========================================
+ Coverage 58% 77% +20%
========================================
Files 369 445 +76
Lines 15942 21060 +5118
Branches 2506 3422 +916
========================================
+ Hits 9135 16211 +7076
+ Misses 6185 4843 -1342
+ Partials 622 6 -616
|
Don Jayamanne (DonJayamanne)
approved these changes
Mar 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix progress reporting for the new LS
Remove 'timeout' tracking since a) progress is not a good indicator of analysis completion and b) 60s may or may not be a timeout. LS is reporting its own telemetry anyway.
Make sure 'begin progress' is called even if there was no explicit notification. The problem is that
onNotificationcannot be attached tolanguageClientuntil it is ready - but LS may produce call tobeginProgresswhile activator is still awaiting on thelanguageClient.readyand hence laterreportProgressgets ignored.Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
Has a news entry file (remember to thank yourself!)Has sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.