Repository navigation
Remove failing tests from test runs temporarily to get builds running: skip unittest.test.ts - #2691
Merged
Conversation
Workaround for microsoft#2684 until we get to the root cause. - unittest.test.ts is failing with the ECONNRESET somewhere in the method.
|
Please create a specific issue for the test that has been disabled. |
Don Jayamanne (DonJayamanne)
approved these changes
Sep 26, 2018
Don Jayamanne (DonJayamanne)
left a comment
Don Jayamanne (DonJayamanne)
left a comment
There was a problem hiding this comment.
Please create a separate issue for the disabled test.
| //tslint:disable-next-line:no-invalid-this | ||
| this.skip(); | ||
|
|
||
| return; |
There was a problem hiding this comment.
fyi - you can change this to a single line return this.skip();
That's what i do. No need to change.
Author
|
#2692 to track the re-enabling of this test suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for #2684 until we get to the root cause.
unittest.test.ts is failing with the ECONNRESET somewhere in the method.
Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
Has a news entry file (remember to thank yourself!)Has unit tests & system/integration testsAny new/changed dependencies inpackage.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)