Fix `No such file or directory` on conda activate by mokeyish · Pull Request #18989 · microsoft/vscode-python

YISH (mokeyish) · 2022-04-24T10:03:32Z

Fix for issue #15818

Deleted user (ghost) · 2022-04-24T11:16:05Z

All CLA requirements met.

Kartik Raj (karrtikr)

Thanks for attempting a fix, although it still seems to be using source instead of conda. The most reliable known solution is to simply replace remove the firstActivate command, and only send conda activate <env>.

YISH (mokeyish) · 2022-04-26T21:40:23Z

Thanks for attempting a fix, although it still seems to be using source instead of conda. The most reliable known solution is to simply replace remove the firstActivate command, and only send conda activate <env>.

Hi karrtikr, using source will be safer than using conda activate
when

# >>> conda initialize >>>
# !! Contents within this block are managed by 'conda init' !!
__conda_setup="$('/home/.share/conda/bin/conda' 'shell.zsh' 'hook' 2> /dev/null)"
if [ $? -eq 0 ]; then
    eval "$__conda_setup"
else
    if [ -f "/home/.share/conda/etc/profile.d/conda.sh" ]; then
        . "/home/.share/conda/etc/profile.d/conda.sh"
    else
        export PATH="/home/.share/conda/bin:$PATH"
    fi
fi
unset __conda_setup
# <<< conda initialize <<<

is not be sourced.

Kartik Raj (karrtikr) · 2022-04-26T22:08:46Z

YISH (@mokeyish), I think the shell hooks in:

'/home/.share/conda/bin/conda' 'shell.zsh' 'hook'

now takes care of the sourcing in the later conda versions. But maybe I'm not understanding it correctly.

Regardless, we're in the process of moving away from constructing our own activation commands to simply using what conda recommends. That way the responsibility of correct activation commands only lies with conda. If you think it's not being sourced and sourcing is necessary, please report that to conda so they can incorporate it as part of conda activate.

For the purposes of this issue #15818, please use conda activate instead.

YISH (mokeyish) · 2022-04-26T22:24:41Z

Kartik Raj (@karrtikr) using conda activate will cause error

conda may not be sourced correctly, So here try to find conda in known paths :

vscode-python/src/client/pythonEnvironments/common/environmentManagers/conda.ts

Line 322 in 03f4ec0

prefixes.push('/usr/share', '/usr/local/share', '/opt');

Kartik Raj (karrtikr)

Thanks for clearing up the reason why source was used in the first place. However it's still a hack that we have to work around conda: #8770 (comment), and we are hesitant to rely completely on it. Let me know if this works out as well:

source ${activatePath}
conda activate ${condaEnv.toCommandArgumentForPythonExt()}

The intention is to send the conda activate command following it, so we do not totally rely on the source command.

Kartik Raj (karrtikr)

Almost there, thanks for working on this.

Kartik Raj (karrtikr) · 2022-04-27T16:22:14Z

+    public async getCondaInfo(): Promise<CondaInfo | undefined> {
+        return this._getCondaInfo();
+    }


This is no longer needed. Also, please turn getCondaFileFromInterpreter into a private method and remove it from the ICondaService interface.

This is still unaddressed.

getCondaInfo is used in condaActivationProvider.ts to check if conda sourced already.

I mean you can remove one of _getCondaInfo in favor of getCondaInfo.

Also, getCondaFileFromInterpreter comment is unaddressed.

Also, getCondaFileFromInterpreter comment is unaddressed.

getCondaFileFromInterpreter is used in another place.

You can still remove it from the ICondaService interface.

It's maybe helpful.

Actually the type of condaService is CondaService, not ICondaService, so it can be removed.

Ideally we should replacing those tests with tests for getActivationScriptFromInterpreter but I'm letting that go.

It's will cause error when I remove getCondaFileFromInterpreter directly.

I have checked your branch and removing it does not cause an error, but okay.

Kartik Raj (karrtikr)

Also please add a news entry file thanking yourself (see news/README.md for instructions).

Ping me Kartik Raj (@karrtikr) or re-request a review once all these comments are addressed.

Kartik Raj (karrtikr)

Implemented suggestion: https://github.com/microsoft/vscode-python/pull/18989/files#r863217723

Kartik Raj (karrtikr)

Lastly, please add some tests for the changes.

Kartik Raj (karrtikr) · 2022-05-09T18:15:09Z

+    public async getCondaInfo(): Promise<CondaInfo | undefined> {
+        return this._getCondaInfo();
+    }


This is still unaddressed.

Kartik Raj (karrtikr)

LGTM once #18989 (comment) is addressed and merge conflicts are resolved.

Kartik Raj (karrtikr) · 2022-05-23T17:02:50Z

YISH (@mokeyish) You might want to run git pull upstream main to resolve merge conflicts with main, after which this can be merged.

Kartik Raj (karrtikr)

Thanks for working on this.

YISH (mokeyish) · 2022-05-24T01:03:20Z

Looking forward to release new version for this as far as quickly.

Kartik Raj (karrtikr) · 2022-05-24T03:33:50Z

Fix should be out in the pre-release version of the extension, you can use the following to try it out:

Birch-san · 2023-01-30T22:41:03Z

This still happened for me in v2022.8.0 and pre-release version v2023.9.10301005.

I installed conda 23.1.0 like this, on Ubuntu 22.10:
https://www.anaconda.com/products/distribution

bash Anaconda-latest-Linux-x86_64.sh
eval "$("$HOME/anaconda3/bin/conda" shell.bash hook)"
conda config --set auto_activate_base false
conda init

I think the problem is that vscode expects an executable to exist at "$HOME/anaconda3/condabin/activate", but there's nothing there. The true location is "$HOME/anaconda3/bin/activate".

Fixed by creating a symlink:

ln -s "$HOME/anaconda3/bin/activate" activate

You can get a better error message (i.e. it reveals which file it was trying to open) if you explicitly specify your conda executable path:

…ython#18989)

github-actions Bot assigned Kim-Adeline Miguel (kimadeline) Apr 24, 2022

YISH (mokeyish) mentioned this pull request Apr 24, 2022

Fix No such file or directory on conda activate #15818

Closed

Kim-Adeline Miguel (kimadeline) requested a review from Kartik Raj (karrtikr) April 25, 2022 15:02

Kim-Adeline Miguel (kimadeline) assigned Kartik Raj (karrtikr) and unassigned Kim-Adeline Miguel (kimadeline) Apr 25, 2022

Kartik Raj (karrtikr) suggested changes Apr 26, 2022

View reviewed changes

Kartik Raj (karrtikr) reviewed Apr 27, 2022

View reviewed changes

Comment thread src/client/pythonEnvironments/common/environmentManagers/conda.ts Outdated

Kartik Raj (karrtikr) reviewed Apr 27, 2022

View reviewed changes

Comment thread src/client/common/terminal/environmentActivationProviders/condaActivationProvider.ts Outdated

Kartik Raj (karrtikr) reviewed Apr 27, 2022

View reviewed changes

Kartik Raj (karrtikr) reviewed May 2, 2022

View reviewed changes

Comment thread src/client/common/terminal/environmentActivationProviders/condaActivationProvider.ts Outdated

cjgh approved these changes May 3, 2022

View reviewed changes

Kartik Raj (karrtikr) reviewed May 6, 2022

View reviewed changes

Kartik Raj (karrtikr) self-requested a review May 9, 2022 16:13

Kartik Raj (karrtikr) reviewed May 9, 2022

View reviewed changes

Kartik Raj (karrtikr) reviewed May 17, 2022

View reviewed changes

cjgh approved these changes May 23, 2022

View reviewed changes

Fix No such file or directory on conda activate

0a7d435

Kartik Raj (karrtikr) approved these changes May 24, 2022

View reviewed changes

Kartik Raj (karrtikr) merged commit ae58f22 into microsoft:main May 24, 2022

Kartik Raj (karrtikr) mentioned this pull request Jun 7, 2022

Python: Create Terminal error command noise included when default shell is fish #4959

Closed

Wes McKinney (wesm) pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024

Fix No such file or directory on conda activate (microsoft/vscode-p…

5a62380

…ython#18989)

Conversation

YISH (mokeyish) commented Apr 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Deleted user (ghost) commented Apr 24, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kartik Raj (karrtikr) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YISH (mokeyish) commented Apr 26, 2022

Uh oh!

Kartik Raj (karrtikr) commented Apr 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YISH (mokeyish) commented Apr 26, 2022

Uh oh!

Kartik Raj (karrtikr) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kartik Raj (karrtikr) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kartik Raj (karrtikr) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kartik Raj (karrtikr) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kartik Raj (karrtikr) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kartik Raj (karrtikr) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kartik Raj (karrtikr) commented May 23, 2022

Uh oh!

Kartik Raj (karrtikr) left a comment

Choose a reason for hiding this comment

Uh oh!

YISH (mokeyish) commented Apr 24, 2022 •

edited

Loading

Deleted user (ghost) commented Apr 24, 2022 •

edited by ghost

Loading

Kartik Raj (karrtikr) left a comment •

edited

Loading

Kartik Raj (karrtikr) commented Apr 26, 2022 •

edited

Loading

Kartik Raj (karrtikr) left a comment •

edited

Loading

Kartik Raj (karrtikr) left a comment •

edited

Loading

Birch-san commented Jan 30, 2023 •

edited

Loading