Repository navigation
Creating new Integrated Terminal doesn't take selected workspace into account when activating environment - #17595
Merged
Conversation
Karthik Nadig (karthiknadig)
requested changes
Oct 1, 2021
| import { ITerminalActivator } from '../common/terminal/types'; | ||
| import { IDisposable, IDisposableRegistry } from '../common/types'; | ||
| import { ITerminalAutoActivation } from './types'; | ||
| import { URI } from 'vscode-uri'; |
Member
There was a problem hiding this comment.
You should add Uri to line 7. We don't need this package.
import { Terminal, Uri } from 'vscode';
Author
|
Thank you for helping me through this. One test fails, is there a way to use the |
|
|
||
| await this.activator.activateEnvironmentInTerminal(terminal, { | ||
| resource: this.activeResourceService.getActiveResource(), | ||
| resource: resource, |
There was a problem hiding this comment.
Suggested change
| resource: resource, | |
| resource, |
That is what it means by property short hand.
There was a problem hiding this comment.
If you install prettier extension, and set that as the formatter for TS. it should automatically do this for you.
There was a problem hiding this comment.
Yes, I'll fix this in a couple of hours from now! Thank you
Author
|
I've formatted the file using Prettier in VSCode and then committed here. Although the details mention to run prettier, is the Tab count making a difference? I use the default number of spaces (8) for tab count as of now. |
Member
|
Vidushi Gupta (@Vidushi-Gupta) use 4 as the number of spaces. If that doesn't work I can fix this on my end. |
Author
|
I changed the number of spaces and then formatted it on Prettier, but the test still fails. Is there anything else that I might be missing? |
used 4 tab spaces in prettier
Karthik Nadig (karthiknadig)
force-pushed
the
main
branch
from
October 4, 2021 19:49
5326bee to
0bbde9b
Compare
Karthik Nadig (karthiknadig)
approved these changes
Oct 4, 2021
Karthik Nadig (karthiknadig)
added a commit
to karthiknadig/vscode-python
that referenced
this pull request
Oct 13, 2021
… account when activating environment (microsoft#17595) * Worked on issue microsoft#15522 * worked on microsoft#15522 issue * added microsoft#15522 issue fix and contributor name * Impored Uri from VSCode * imported Uri correctly * imported Uri correctly * used short hand property on line 61 * formatted document using prettier * formatted code using prettier * formatted code using prettier * updated formatting of the document used 4 tab spaces in prettier * Fix formatting. Co-authored-by: Karthik Nadig <[email protected]>
Karthik Nadig (karthiknadig)
added a commit
that referenced
this pull request
Oct 13, 2021
… account when activating environment (#17595) * Worked on issue #15522 * worked on #15522 issue * added #15522 issue fix and contributor name * Impored Uri from VSCode * imported Uri correctly * imported Uri correctly * used short hand property on line 61 * formatted document using prettier * formatted code using prettier * formatted code using prettier * updated formatting of the document used 4 tab spaces in prettier * Fix formatting. Co-authored-by: Karthik Nadig <[email protected]>
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
… account when activating environment (microsoft/vscode-python#17595) * Worked on issue microsoft/vscode-python#15522 * worked on microsoft/vscode-python#15522 issue * added microsoft/vscode-python#15522 issue fix and contributor name * Impored Uri from VSCode * imported Uri correctly * imported Uri correctly * used short hand property on line 61 * formatted document using prettier * formatted code using prettier * formatted code using prettier * updated formatting of the document used 4 tab spaces in prettier * Fix formatting. Co-authored-by: Karthik Nadig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please let me know if there are any changes that I would have to make to this. Looking forward to contributing to Open Source!