Skip to content

Fix bug, remove unnecessary flag, fix hash comparison on Linux - #1734

Merged
Mikhail Arkhipov (MikhailArkhipov) merged 86 commits into
microsoft:masterfrom
MikhailArkhipov:analysis
May 23, 2018
Merged

Fix bug, remove unnecessary flag, fix hash comparison on Linux#1734
Mikhail Arkhipov (MikhailArkhipov) merged 86 commits into
microsoft:masterfrom
MikhailArkhipov:analysis

Conversation

@MikhailArkhipov

@MikhailArkhipov Mikhail Arkhipov (MikhailArkhipov) commented May 23, 2018

Copy link
Copy Markdown

Fixes #1717

  • Remove flag that is obsolete
  • Fix case in hash comparison

This pull request:

  • Has a title summarizes what is changing
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

MikhailArkhipov and others added 30 commits March 27, 2018 14:58
MikhailArkhipov
Undo changes
a764bc9
MikhailArkhipov
Test fixes
9d1b2cc
Mikhail Arkhipov
Increase timeout
a91291a
MikhailArkhipov
Remove double event listening
bf266af
MikhailArkhipov
Remove test
7bc6bd6
MikhailArkhipov
Revert "Remove test"
8ce8b48 
This reverts commit e240c3f.
MikhailArkhipov
Revert "Remove double event listening"
e3a549e 
This reverts commit af573be.
MikhailArkhipov
#1096 The if statement is automatically formatted incorrectly
92e8c1e
MikhailArkhipov
Merge fix
b540a1d
MikhailArkhipov
Add more tests
7b0573e
MikhailArkhipov
More tests
facb106
MikhailArkhipov
Typo
f113881
Mikhail Arkhipov
Test
3e76718
Mikhail Arkhipov
Also better handle multiline arguments
6e85dc6
@brettcannon
Add a couple missing periods
99e037c 
[skip ci]
MikhailArkhipov
Undo changes
3caeab7
MikhailArkhipov
Test fixes
eeb1f11
Mikhail Arkhipov
Increase timeout
f5f78c7
MikhailArkhipov
Remove double event listening
88744da
MikhailArkhipov
Remove test
65dde44
MikhailArkhipov
Revert "Remove test"
c513f71 
This reverts commit e240c3f.
MikhailArkhipov
Revert "Remove double event listening"
ccb3886 
This reverts commit af573be.
MikhailArkhipov
Merge fix
106f4db
MikhailArkhipov
Merge branch 'master' of https://github.com/MikhailArkhipov/vscode-py…
9e5cb43 
…thon
MikhailArkhipov
#1257 On type formatting errors for args and kwargs
e1da6a6
MikhailArkhipov
Handle f-strings
e78f0fb
MikhailArkhipov
Stop importing from test code
725cf71
MikhailArkhipov
#1308 Single line statements leading to an indentation on the next line
5cd6d45
MikhailArkhipov
#726 editing python after inline if statement invalid indent
27613db
MikhailArkhipov
Undo change
8061a20
MikhailArkhipov added 26 commits May 3, 2018 13:06
MikhailArkhipov
Pythia setting
abff213
MikhailArkhipov
Baseline updates
d140b3a
MikhailArkhipov
Baseline update
4b394d9
Mikhail Arkhipov
Improve startup
a397b11
MikhailArkhipov
Handle missing interpreter better
e54eaf8
MikhailArkhipov
Handle interpreter change
3b8ddd5
MikhailArkhipov
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
9a4500d 
…nto analysis
MikhailArkhipov
Delete old file
41f9624
MikhailArkhipov
Fix LS startup time reporting
3627b85
MikhailArkhipov
Remove Async suffix from IFileSystem
486d11d
MikhailArkhipov
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
cf5cf9c 
…nto analysis
Mikhail Arkhipov
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
4913e28 
…nto analysis
MikhailArkhipov
Remove Pythia
84214e1
MikhailArkhipov
Remove pre-packaged MSIL
9c1adb1
MikhailArkhipov
Exe name on Unix
5a6e546
MikhailArkhipov
Plain linux
1f2ae09
Mikhail Arkhipov
Fix casing
f972614
Mikhail Arkhipov
Merge branch 'analysis' of https://github.com/MikhailArkhipov/vscode-…
e0021a9 
…python into analysis
MikhailArkhipov
Fix message
d2721cd
MikhailArkhipov
Merge branch 'analysis' of https://github.com/MikhailArkhipov/vscode-…
b8bc0a2 
…python into analysis
MikhailArkhipov
Update PTVS engine activation steps
56d34f7
MikhailArkhipov
Merge branch 'analysis' of https://github.com/MikhailArkhipov/vscode-…
9aab160 
…python into analysis
MikhailArkhipov
Type formatter eats space in from .
981290f
MikhailArkhipov
fIX CASING
d279e96
MikhailArkhipov
Remove flag
6b466a9
MikhailArkhipov
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
d8c6193 
…nto analysis
@codecov

codecov Bot commented May 23, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1734 into master will increase coverage by 0.21%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1734      +/-   ##
==========================================
+ Coverage   73.56%   73.77%   +0.21%     
==========================================
  Files         279      279              
  Lines       13060    13049      -11     
  Branches     2328     2329       +1     
==========================================
+ Hits         9607     9627      +20     
+ Misses       3314     3289      -25     
+ Partials      139      133       -6
Impacted Files Coverage Δ
src/client/activation/downloader.ts 19.31% <ø> (+2.01%) ⬆️
src/client/activation/analysis.ts 15.26% <ø> (ø) ⬆️
src/client/common/configSettings.ts 88.09% <ø> (+0.44%) ⬆️
src/client/common/types.ts 100% <ø> (ø) ⬆️
src/client/activation/hashVerifier.ts 23.52% <0%> (ø) ⬆️
src/client/formatters/lineFormatter.ts 98.36% <100%> (+0.06%) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (ø) ⬆️
src/client/debugger/mainV2.ts 78.71% <0%> (+0.8%) ⬆️
src/client/debugger/PythonProcess.ts 51.25% <0%> (+5.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9022527...d8c6193. Read the comment docs.

@MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov) merged commit eee1529 into microsoft:master May 23, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne Don Jayamanne (DonJayamanne) DonJayamanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

Type formatter eats space in from .

3 participants

@MikhailArkhipov @DonJayamanne @brettcannon