Ensure we block on autoselection when no interpreter is explictly set by user#16723
Merged
karrtikr merged 3 commits intomicrosoft:release-2021.07from Jul 20, 2021
Merged
Ensure we block on autoselection when no interpreter is explictly set by user#16723karrtikr merged 3 commits intomicrosoft:release-2021.07from
karrtikr merged 3 commits intomicrosoft:release-2021.07from
Conversation
karthiknadig
approved these changes
Jul 19, 2021
kimadeline
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
It works! 🥳
I am hitting a second problem, although that might be by design:
- The first time
updateDisplayis called the interpreter ispython, so it will trigger auto-selection, so far so good; - The auto-selection logic will query
interpreterService.getInterpreters, and it will return only the cached interpreters, so the interpreter that will be displayed in the status bar is going to be one of my global interpreters; - Then the auto-selection will be triggered again, this time by
ExtensionActivationManager.activate, and this time the local virtual environment selected will be returned, but there is noupdateDisplaycall to reflect that change.
I assume 2. is by design, so do we want to do anything about it? I will file a separate issue: #16727
Member
|
@kimadeline @karrtikr I think 2 is a problem but in the discovery code. For globals it should return cached. For locals it should return cached local environments, if there are none cached then it should looks for one and return anything it finds. |
added 2 commits
July 19, 2021 18:48
Author
|
@karthiknadig For now to keep things simple we decided to ignore cache for both global and local envs the first time. If we have performance issues we can optimize it later. |
karthiknadig
added a commit
that referenced
this pull request
Jul 22, 2021
* Fix 'Cannot read property 'resolveEnv' of undefined' error (#16677) * Cherry pick fixes into release (#16686) * Bump actions/setup-node from 2.1.5 to 2.2.0 (#16592) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.1.5 to 2.2.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.1.5...v2.2.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for starting TensorBoard session with a remote log directory via URL (#16477) * Add support for remote logdirs * Add missing keys * Fix typo * Bump isort from 5.8.0 to 5.9.2 (#16636) Bumps [isort](https://github.com/pycqa/isort) from 5.8.0 to 5.9.2. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@5.8.0...5.9.2) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Make getInterpreters() API faster for subsequent calls (#16674) * Change the way auto-selection works (#16644) * New comparison logic * Add experiment group * Register and call it * Add service registry tests * Add interpreter selector unit tests * Add comparison unit tests * Add intepreter selector test * News file * Adjust comments * Reuse getSortName * Add new auto-selection logic * Add tests for getEnvTypeHeuristic * Move persistent store initialization back out * Update tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joyce Er <[email protected]> Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]> * Change version for release (#16722) * Ensure we block on autoselection when no interpreter is explictly set by user (#16723) * Ensure we block on autoselection when no interpreter is explictly set by user * Added tests * News entry * Update change log for release. (#16731) * Fix autoselection when opening a python file directly (#16733) * Fix autoselection when opening a python file directly * Update changelog * Add tests * Ignore cache when querying for interpreters during auto-selection (#16734) * Ignore cache when getting envs for autoselection * Don't call autoSelectInterpreter twice * Update debugger via point release (#16746) * Update version * Update change log * Update wheels to 3.9 (#16745) * Clean up Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joyce Er <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]>
karthiknadig
added a commit
that referenced
this pull request
Jul 28, 2021
* Fix 'Cannot read property 'resolveEnv' of undefined' error (#16677) * Cherry pick fixes into release (#16686) * Bump actions/setup-node from 2.1.5 to 2.2.0 (#16592) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.1.5 to 2.2.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.1.5...v2.2.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for starting TensorBoard session with a remote log directory via URL (#16477) * Add support for remote logdirs * Add missing keys * Fix typo * Bump isort from 5.8.0 to 5.9.2 (#16636) Bumps [isort](https://github.com/pycqa/isort) from 5.8.0 to 5.9.2. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@5.8.0...5.9.2) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Make getInterpreters() API faster for subsequent calls (#16674) * Change the way auto-selection works (#16644) * New comparison logic * Add experiment group * Register and call it * Add service registry tests * Add interpreter selector unit tests * Add comparison unit tests * Add intepreter selector test * News file * Adjust comments * Reuse getSortName * Add new auto-selection logic * Add tests for getEnvTypeHeuristic * Move persistent store initialization back out * Update tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joyce Er <[email protected]> Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]> * Change version for release (#16722) * Ensure we block on autoselection when no interpreter is explictly set by user (#16723) * Ensure we block on autoselection when no interpreter is explictly set by user * Added tests * News entry * Update change log for release. (#16731) * Fix autoselection when opening a python file directly (#16733) * Fix autoselection when opening a python file directly * Update changelog * Add tests * Ignore cache when querying for interpreters during auto-selection (#16734) * Ignore cache when getting envs for autoselection * Don't call autoSelectInterpreter twice * Update debugger via point release (#16746) * Update version * Update change log * Update wheels to 3.9 (#16745) * Point release with debugpy fix (#16776) Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joyce Er <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will add tests once @kimadeline confirms this fixes the issue.