Skip to content

Fix npm audit vulnerabilities#16658

Closed
paulacamargo25 wants to merge 17 commits intomicrosoft:mainfrom
paulacamargo25:16148-Fix-npm-audit-vulnerabilities
Closed

Fix npm audit vulnerabilities#16658
paulacamargo25 wants to merge 17 commits intomicrosoft:mainfrom
paulacamargo25:16148-Fix-npm-audit-vulnerabilities

Conversation

@paulacamargo25
Copy link
Copy Markdown

@paulacamargo25 paulacamargo25 commented Jul 12, 2021

Closed #318.

@paulacamargo25 paulacamargo25 added the no-changelog No news entry required label Jul 12, 2021
@brettcannon brettcannon reopened this Jul 13, 2021
@karthiknadig karthiknadig self-requested a review July 14, 2021 20:12
Comment thread src/client/common/net/httpClient.ts
@paulacamargo25 paulacamargo25 marked this pull request as ready for review July 15, 2021 21:34
@karrtikr karrtikr removed their request for review July 15, 2021 22:55
@github-actions github-actions Bot requested a review from karrtikr July 15, 2021 22:55
Copy link
Copy Markdown

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I have left one comment which needs verification and tests that needs to be fixed.

Comment thread src/client/pythonEnvironments/common/pythonBinariesWatcher.ts
Comment thread src/client/pythonEnvironments/discovery/locators/services/windowsStoreLocator.ts Outdated
@paulacamargo25 paulacamargo25 force-pushed the 16148-Fix-npm-audit-vulnerabilities branch from f240a22 to d3cfa6e Compare July 21, 2021 22:20
@paulacamargo25 paulacamargo25 force-pushed the 16148-Fix-npm-audit-vulnerabilities branch from beaaa84 to f2515cb Compare July 26, 2021 20:00
@paulacamargo25 paulacamargo25 requested a review from karrtikr July 27, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants