Skip to content

Improve detection of the function argument list in autoformat - #1508

Merged
Mikhail Arkhipov (MikhailArkhipov) merged 41 commits into
microsoft:masterfrom
MikhailArkhipov:master
Apr 27, 2018
Merged

Improve detection of the function argument list in autoformat#1508
Mikhail Arkhipov (MikhailArkhipov) merged 41 commits into
microsoft:masterfrom
MikhailArkhipov:master

Conversation

@MikhailArkhipov

@MikhailArkhipov Mikhail Arkhipov (MikhailArkhipov) commented Apr 26, 2018

Copy link
Copy Markdown

Fixes #1505

  • Analyze previous line for more reliability
  • Add more tests

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry - there is one with AF improvements AFAIK
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

MikhailArkhipov and others added 30 commits March 27, 2018 14:58
MikhailArkhipov
Undo changes
a764bc9
MikhailArkhipov
Test fixes
9d1b2cc
Mikhail Arkhipov
Increase timeout
a91291a
MikhailArkhipov
Remove double event listening
bf266af
MikhailArkhipov
Remove test
7bc6bd6
MikhailArkhipov
Revert "Remove test"
8ce8b48 
This reverts commit e240c3f.
MikhailArkhipov
Revert "Remove double event listening"
e3a549e 
This reverts commit af573be.
MikhailArkhipov
#1096 The if statement is automatically formatted incorrectly
92e8c1e
MikhailArkhipov
Merge fix
b540a1d
MikhailArkhipov
Add more tests
7b0573e
MikhailArkhipov
More tests
facb106
MikhailArkhipov
Typo
f113881
Mikhail Arkhipov
Test
3e76718
Mikhail Arkhipov
Also better handle multiline arguments
6e85dc6
@brettcannon
Add a couple missing periods
99e037c 
[skip ci]
MikhailArkhipov
Undo changes
3caeab7
MikhailArkhipov
Test fixes
eeb1f11
Mikhail Arkhipov
Increase timeout
f5f78c7
MikhailArkhipov
Remove double event listening
88744da
MikhailArkhipov
Remove test
65dde44
MikhailArkhipov
Revert "Remove test"
c513f71 
This reverts commit e240c3f.
MikhailArkhipov
Revert "Remove double event listening"
ccb3886 
This reverts commit af573be.
MikhailArkhipov
Merge fix
106f4db
MikhailArkhipov
Merge branch 'master' of https://github.com/MikhailArkhipov/vscode-py…
9e5cb43 
…thon
MikhailArkhipov
#1257 On type formatting errors for args and kwargs
e1da6a6
MikhailArkhipov
Handle f-strings
e78f0fb
MikhailArkhipov
Stop importing from test code
725cf71
MikhailArkhipov
#1308 Single line statements leading to an indentation on the next line
5cd6d45
MikhailArkhipov
#726 editing python after inline if statement invalid indent
27613db
MikhailArkhipov
Undo change
8061a20
@MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov) merged commit f7e4529 into microsoft:master Apr 27, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne Don Jayamanne (DonJayamanne) DonJayamanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

Auto formatting (format as you type) removes spaces when it shouldn't

3 participants

@MikhailArkhipov @DonJayamanne @brettcannon