Skip to content

Port prune fix from main to release#14243

Merged
rchiodo merged 2 commits intorelease-2020.09from
rchiodo/port_prune_fix
Oct 5, 2020
Merged

Port prune fix from main to release#14243
rchiodo merged 2 commits intorelease-2020.09from
rchiodo/port_prune_fix

Conversation

@rchiodo
Copy link
Copy Markdown

@rchiodo rchiodo commented Oct 2, 2020

For #11151

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

* Remove transient output when exporting from the interactive window

* Add news entry
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 2, 2020

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59%. Comparing base (8022bfe) to head (67f1012).

Files with missing lines Patch % Lines
src/client/datascience/jupyter/jupyterExporter.ts 50% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2020.09   #14243   +/-   ##
================================================
- Coverage               59%      59%   -1%     
================================================
  Files                  692      692           
  Lines                38362    38363    +1     
  Branches              5519     5519           
================================================
- Hits                 22959    22951    -8     
- Misses               14218    14224    +6     
- Partials              1185     1188    +3     
Files with missing lines Coverage Δ
src/client/datascience/common.ts 60% <100%> (ø)
src/client/datascience/jupyter/jupyterExporter.ts 16% <50%> (+<1%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rchiodo rchiodo merged commit aaca611 into release-2020.09 Oct 5, 2020
@rchiodo rchiodo deleted the rchiodo/port_prune_fix branch October 5, 2020 16:06
rchiodo added a commit that referenced this pull request Oct 7, 2020
* Port ipykernel install fix to release (#13975)

* Fix installing ipykernel into interpreters for raw kernel (#13959)

* update news

Co-authored-by: Ian Huff <[email protected]>

* Merge in changes to release (#13976)

* Up release version for new release (#13928)

* Up release version

* Update changelog

* Update changelog

* Workaround test issue (#13930)

* Try different version of VS code in release

* Change to make it use the actual variable

* Use a real version

* More tests failing with gpu error (#13935)

* Try different version of VS code in release

* Change to make it use the actual variable

* Use a real version

* Two more version changes

* Fix kernel and server name missing in certain situations (#13974)

* Fix kernel name and server name

* Fixup server name for remote situations

* Add some functional tests

* Add news entry

* Delete news file

* Port two fixes to the release branch (#13995)

* Disable split views of custom editors (#13985)

* Fix backup storage by looking at the options correctly (#13983)

* Fix backup storage by looking at the options correctly

* Fix backup by being more explicit

* Only linux tests are failing. Hopefully fix them

* Fixup changelog

Co-authored-by: Don Jayamanne <[email protected]>

* add jedi-language-server to 3rd party notices (#13977)

* add jedi-language-server to 3rd party notices

* move license from distribution to repository file

* disable test_discover_complex_default and (#14024)

test_discover_complex_doctest

* Upgrade isort to 5.5.3 (#14035) (#14037)

* prepare release (#14042)

* fixed annoying warnings (#14049)

* Cherry pick to address path issues. (#14125)

* Do not quote isolated in exec module (#14108)

* Do not quote isolated in exec module

* Revert "Do not quote isolated in exec module"

This reverts commit b9fa04c.

* Revert "IPyKernel install issue with windows paths (#13667)"

This reverts commit 23725ab.

* Fix unit test broken by recent revert (#14122)

* Port escape fix to release branch (#14133)

* Fix HTML escaping to match what Jupyter does (#14038)

* Basic idea

* add some functional tests

* Add news entry

* Fix functional tests

* Update changelog

* update version and changelog (#14139)

* Escaping fix broke a number of things (#14145) (#14154)

* Fixes for escaping

* Push a comment ot start PR again

* Cache task is failing

* Remove cache task

* Not fixing so just put back cache task

* Port NB Convert Fix to point release branch (#14200)

* Port escape fix to release branch (#14202)

* A different way of fixing escaping (#14186)

* Move escaping to just output

* Add some tests to verify round tripping

* Fixup test for rountrip and make roundtripping actually work

* Add news entry

* Add to manual test file

* Fix streaming problem and add more to the test

* Fix traceback unit test

* Fix problem caught by functional tests :)

* Another functional test catch

* Update changelog

* Port interactive window export fix (#14232)

* Select kernel based on metadata in notebook (#14217) (#14234)

* Fix picking kernel based on metadata

* Port more escape fixes to point release (#14242)

* Fix two problems with escaping (#14228)

* Fixup changelog

* Port prune fix from main to release (#14243)

* Remove unneeded cell keys when exporting (#14241)

* Remove transient output when exporting from the interactive window

* Add news entry

* Update changelog

* Merge fixes related to remembering interpreter (#14270)

* update version, changelog and thrid party notices (#14280)

* remove VSC_PYTHON_CI_TEST_VSC_CHANNEL
and test skips

* delete ipynb file

* delete solved news files

* delete more news

Co-authored-by: Ian Huff <[email protected]>
Co-authored-by: Ian Huff <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>
Co-authored-by: Don Jayamanne <[email protected]>
Co-authored-by: Kartik Raj <[email protected]>
Co-authored-by: Karthik Nadig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants