Skip to content

Envs cache initialization#14180

Merged
kimadeline merged 3 commits intomicrosoft:mainfrom
kimadeline:envs-cache-initialization
Oct 2, 2020
Merged

Envs cache initialization#14180
kimadeline merged 3 commits intomicrosoft:mainfrom
kimadeline:envs-cache-initialization

Conversation

@kimadeline
Copy link
Copy Markdown

@kimadeline kimadeline commented Sep 30, 2020

Follow-up to #14065, see #14065 (comment).

This (still) impacts #14020.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Sep 30, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 30, 2020 •
edited
Loading

Codecov Report

Merging #14180 into main will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14180      +/-   ##
==========================================
- Coverage   59.95%   59.94%   -0.01%     
==========================================
  Files         706      706              
  Lines       39135    39138       +3     
  Branches     5674     5674              
==========================================
  Hits        23463    23463              
- Misses      14438    14440       +2     
- Partials     1234     1235       +1
Impacted Files Coverage Δ
src/client/pythonEnvironments/index.ts 17.07% <33.33%> (+1.28%) ⬆️
src/client/common/utils/platform.ts 68.00% <0.00%> (-4.00%) ⬇️
src/client/common/process/proc.ts 15.21% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b6d8f...7eb426b. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review September 30, 2020 19:46
ericsnowcurrently
ericsnowcurrently approved these changes Sep 30, 2020
View reviewed changes
Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one small thing, LGTM.

Comment thread src/client/extensionInit.ts
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kimadeline kimadeline merged commit ae84247 into microsoft:main Oct 2, 2020
@kimadeline kimadeline deleted the envs-cache-initialization branch October 2, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

+1 more reviewer

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kimadeline @codecov-commenter @ericsnowcurrently @karthiknadig