Repository navigation
Add telemetry reporting on VS analysis engine usage - #1382
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 37 commits intoApr 13, 2018
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 37 commits into
Mikhail Arkhipov (MikhailArkhipov) merged 37 commits into
Conversation
added 6 commits
April 5, 2018 15:59
Codecov Report
@@ Coverage Diff @@
## master #1382 +/- ##
=========================================
Coverage ? 71.06%
=========================================
Files ? 269
Lines ? 12430
Branches ? 2199
=========================================
Hits ? 8833
Misses ? 3464
Partials ? 133
Continue to review full report at Codecov.
|
| } catch (ex) { | ||
| if (await this.isDotNetInstalled()) { | ||
| this.appShell.showErrorMessage(`.NET Runtime appears to be installed but the language server did not start. Error ${ex}`); | ||
| reporter.sendTelemetryEvent(PYTHON_ANALYSIS_ENGINE_ERROR, { error: 'Failed to start (MSIL)' }); |
Don Jayamanne (DonJayamanne)
approved these changes
Apr 12, 2018
| const sw = new StopWatch(); | ||
| lc.clientOptions.errorHandler = new LanguageServerStartupErrorHandler(deferred); | ||
|
|
||
| disposable = lc.start(); |
There was a problem hiding this comment.
disposable = lc.start();
lc.onReady()
.then(() => deferred.resolve())
.catch(ex => deferred.reject());
await deferred.promise;You might want to change to .catch(deferred.reject);
This way the error is rethrown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1016
This pull request: