Limit python.languageServer setting scope to window#13246
Merged
MikhailArkhipov merged 18 commits intomicrosoft:masterfrom Aug 4, 2020
MikhailArkhipov:lsset
Merged
Limit python.languageServer setting scope to window#13246MikhailArkhipov merged 18 commits intomicrosoft:masterfrom MikhailArkhipov:lsset
python.languageServer setting scope to window#13246MikhailArkhipov merged 18 commits intomicrosoft:masterfrom
MikhailArkhipov:lsset
Conversation
added 18 commits
May 5, 2020 21:15
MikhailArkhipov
added
area-intellisense
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #13246 +/- ##
==========================================
+ Coverage 59.64% 59.80% +0.15%
==========================================
Files 670 670
Lines 36830 37235 +405
Branches 5188 5286 +98
==========================================
+ Hits 21968 22268 +300
- Misses 13770 13833 +63
- Partials 1092 1134 +42
Continue to review full report at Codecov.
|
Member
|
I'm sure you tested it, but did you notice any oddities? I know we already have loads of settings set to "resource" that really shouldn't be, but are. |
jakebailey
approved these changes
Aug 4, 2020
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Tested it, seems to work fine in the expected cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pylance does not support per-folder LS instances and
MPLS v1does not reliably work in this case anyway. This simplifies transition of setting fromv1toPylance.- [ ] Has a news entry file (remember to thank yourself!).- [ ] Appropriate comments and documentation strings in the code.- [ ] Has sufficient logging.- [ ] Has telemetry for enhancements.- [ ] Unit tests & system/integration tests are added/updated.- [ ] Test plan is updated as appropriate.- [ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).- [ ] The wiki is updated with any design decisions/details.