Include notebook renderers in extension#12793
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
force-pushed
the
prepForNative
branch
from
20517fe to
b4af150
Compare
| viewType: 'jupyter-notebook', | ||
| filenamePattern: '*.ipynb' | ||
| }); | ||
| await settings.update('editorAssociations', editorAssociations, ConfigurationTarget.Global); |
There was a problem hiding this comment.
As the package.json contains the necessary bits, we just need to update the users settings.json file to pick our notebook viewer as the default viewer for ipynb file.
| await buildWebPackForDevOrProduction('./build/webpack/webpack.datascience-ui-notebooks.config.js', 'production'); | ||
| await buildWebPackForDevOrProduction('./build/webpack/webpack.datascience-ui-viewers.config.js', 'production'); | ||
| await buildWebPackForDevOrProduction('./build/webpack/webpack.extension.config.js', 'extension'); | ||
| await buildWebPackForDevOrProduction('./build/webpack/webpack.datascience-ui-renderers.config.js', 'production'); |
There was a problem hiding this comment.
Shipping renderers in extension.
This is a fallback until we get Renderers extension published.
| "languageServerVersion": "0.5.30", | ||
| "publisher": "ms-python", | ||
| "enableProposedApi": false, | ||
| "enableProposedApi": true, |
There was a problem hiding this comment.
Shipping in VSIX & used only in insiders.
There was a problem hiding this comment.
Doesn't this mess up using without the notebook editor? Or did VS code fix that problem?
There was a problem hiding this comment.
Yes they did, and the fix will be in the next stable release (I think today or tomorrow). Hence the need to wait for their new release.
| private async enableNotebooks(useVSCodeNotebookAsDefaultEditor: boolean) { | ||
| private async enableNotebooks() { | ||
| if (this.env.channel === 'stable') { | ||
| this.shell.showErrorMessage(DataScience.previewNotebookOnlySupportedInVSCInsiders()).then(noop, noop); |
There was a problem hiding this comment.
Existing code ensures notebooks gets used only in insiders.
DonJayamanne
requested review from
DavidKutu,
IanMatthewHuff,
greazer,
joyceerhl,
karthiknadig,
rchiodo and
techwithtim
3 participants
For #10496