Skip to content

Fix arrowing down through cells#11095

Merged
rchiodo merged 1 commit intomasterfrom
rchiodo/arrow_down
Apr 11, 2020
Merged

Fix arrowing down through cells#11095
rchiodo merged 1 commit intomasterfrom
rchiodo/arrow_down

Conversation

@rchiodo
Copy link
Copy Markdown

@rchiodo rchiodo commented Apr 10, 2020

For #11094

@rchiodo rchiodo self-assigned this Apr 10, 2020
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

IanMatthewHuff
IanMatthewHuff approved these changes Apr 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rchiodo Maybe add a test as we've regressed this once now?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 10, 2020 •
edited
Loading

Codecov Report

Merging #11095 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11095      +/-   ##
==========================================
- Coverage   61.42%   61.39%   -0.04%     
==========================================
  Files         597      597              
  Lines       32756    32761       +5     
  Branches     4631     4633       +2     
==========================================
- Hits        20121    20114       -7     
- Misses      11619    11629      +10     
- Partials     1016     1018       +2
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
...ence/ipywidgets/localWidgetScriptSourceProvider.ts 88.13% <0.00%> (-3.39%) ⬇️
...t/common/application/webPanels/webPanelProvider.ts 32.14% <0.00%> (-2.48%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/common/application/types.ts 100.00% <0.00%> (ø)
src/client/datascience/activation.ts 94.44% <0.00%> (+0.15%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af7c29...9d3e163. Read the comment docs.

@rchiodo rchiodo merged commit 49f2c4c into master Apr 11, 2020
rchiodo added a commit that referenced this pull request Apr 11, 2020
@rchiodo
Fix arrowing down through cells (#11095)
4ccac22
@rchiodo rchiodo deleted the rchiodo/arrow_down branch April 13, 2020 16:06
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@greazer greazer Awaiting requested review from greazer

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

@rchiodo rchiodo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rchiodo @codecov-io @IanMatthewHuff