Skip to content

Skip all the createWriteStream() functional tests on OSX. #10449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eric Snow (ericsnowcurrently) merged 1 commit into from
Mar 6, 2020
Merged

Skip all the createWriteStream() functional tests on OSX. #10449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/test/common/platform/filesystem.functional.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,17 @@ suite('FileSystem - raw', () => {
});

suite('createWriteStream', () => {
setup(function() {
if (OSX) {
// tslint:disable-next-line:no-suspicious-comment
// TODO(GH-10031) This appears to be producing
// false negative test results, so we're skipping
// it for now.
// tslint:disable-next-line:no-invalid-this
this.skip();
}
});

test('returns the correct WriteStream', async () => {
const filename = await fix.resolve('x/y/z/spam.py');
const expected = fs.createWriteStream(filename);
Expand Down Expand Up @@ -290,15 +301,7 @@ suite('FileSystem - raw', () => {
await assertFileText(filename, data);
});

test('overwrites existing file', async function() {
if (OSX) {
// tslint:disable-next-line:no-suspicious-comment
// TODO(GH-10031) This appears to be producing
// false negative test results, so we're skipping
// it for now.
// tslint:disable-next-line:no-invalid-this
this.skip();
}
test('overwrites existing file', async () => {
const filename = await fix.createFile('x/y/z/spam.py', '...');
const data = 'line1\nline2\n';

Expand Down