Repository navigation
Skip all the createWriteStream() functional tests on OSX. - #10449
Merged
Eric Snow (ericsnowcurrently) merged 1 commit intoMar 6, 2020
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #10449 +/- ##
==========================================
- Coverage 60.95% 60.94% -0.02%
==========================================
Files 571 578 +7
Lines 30809 31190 +381
Branches 4387 4429 +42
==========================================
+ Hits 18779 19008 +229
- Misses 11077 11216 +139
- Partials 953 966 +13
Continue to review full report at Codecov.
|
Eric Snow (ericsnowcurrently)
requested a review
from Kim-Adeline Miguel (kimadeline)
March 5, 2020 22:42
Kartik Raj (karrtikr)
approved these changes
Mar 6, 2020
Eric Snow (ericsnowcurrently)
deleted the
fix-9953-skip-createWriteStream-functional-tests-on-OSX
branch
March 6, 2020 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #9953)
A while back we skipped one of the "raw" createWriteStream() functional tests (but only on OSX). However, other tests in the same suite are having the same problem. So we are skipping all the tests in the suite for now (to be resolved in #10031).