Fix order of cells inserted#10229
Merged
DonJayamanne merged 1 commit intomicrosoft:ds/custom_editorfrom Feb 21, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## ds/custom_editor #10229 +/- ##
===================================================
Coverage ? 60.83%
===================================================
Files ? 567
Lines ? 30586
Branches ? 4363
===================================================
Hits ? 18608
Misses ? 11031
Partials ? 947Continue to review full report at Codecov.
|
DavidKutu
approved these changes
Feb 20, 2020
DonJayamanne
force-pushed
the
fixInsertionOfCells
branch
from
7bb56c0 to
c4b8fde
Compare
rchiodo
approved these changes
Feb 21, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Author
|
Force merging as branch is broken due to CI/GitHub issues (wrong jobs were flagged as |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cells weren't inserted into the model in the right order.
abAdded https://github.com/microsoft/vscode-python/issues/10230 and moved into backlog and assigned to ds_editor epic. I think in light of this issue it must be done. Else it'll be bad for users to report this.