Refactor how messages are posted to reducers and to the extension#10019
Merged
DonJayamanne merged 1 commit intomicrosoft:ds/custom_editorfrom Feb 10, 2020
Merged
Refactor how messages are posted to reducers and to the extension#10019DonJayamanne merged 1 commit intomicrosoft:ds/custom_editorfrom
DonJayamanne merged 1 commit intomicrosoft:ds/custom_editorfrom
Conversation
DonJayamanne
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## ds/custom_editor #10019 +/- ##
===================================================
Coverage ? 60.8%
===================================================
Files ? 564
Lines ? 29882
Branches ? 4492
===================================================
Hits ? 18171
Misses ? 10718
Partials ? 993Continue to review full report at Codecov.
|
IanMatthewHuff
approved these changes
Feb 10, 2020
DavidKutu
approved these changes
Feb 10, 2020
DonJayamanne
added a commit
that referenced
this pull request
Feb 12, 2020
* Some how I had not included some of the other remaining arg.queueAction into the original PR #10019 * This PR merely brings them from (I had these in the same branch, but failed to include them). * Same as #10019, just a refactor to use a common function to create an action and dispatch it in one step. & removed some of the old syncing stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than having a developer call
createand thenarg.queue, this replaces that with one function.Hides the intricacies of how something is posted or queued.
Also allows us to add additional logic to control what messages can be posted (for synchronization) instead of developer having to do this in every reducer.
Simple harmless refactor