Skip to content

Don't show test library prompt if interpreter is not selected #9614

Closed

Description

No description provided.

Activity

  1. luabud commented on Jan 15, 2020

    @luabud
    Member

    This will change in activateUnsafe in extensions.js. Activate the test frameworks later (after interpreter discovery)

  2. ericsnowcurrently commented on Jan 24, 2020

    @ericsnowcurrently

    (on linux)

    I was able to validate the solution using the following settings.json:

    {
        "python.testing.autoTestDiscoverOnSaveEnabled": true,
        "python.testing.pytestEnabled": true,
        //
        "python.linting.enabled": true,
        "python.linting.flake8Enabled": true,
        //
        "editor.formatOnSave": true,
        "python.formatting.provider": "black",
        //
        "python.pythonPath": "spamspamspam"
    }
    

    I checked to make sure the extension did not have an environment select and clicked on "discover" icon in the test explorer. There was no prompt. If I then selected a fresh venv (nothing installed) and clicked the icon, I got prompted.

  3. karrtikr commented on Jan 24, 2020

    @karrtikr

    But you needed to click the icon, that should not've happened. :( (I can also verify I needed to click the icon)
    We'll have to investigate this.

  4. karthiknadig commented on Jan 24, 2020

    @karthiknadig
    MemberAuthor

    Kartik Raj (@karrtikr) that would be a separate issue right?

  5. karrtikr commented on Jan 30, 2020

    @karrtikr

    Yes that's a different one, we can close this.

  6. luabud commented on Jan 31, 2020

    @luabud
    Member

    Kartik Raj (@karrtikr)

    We'll have to investigate this.

    Is this being tracked anywhere (or does it have to be tracked)?

  7. karrtikr commented on Jan 31, 2020

    @karrtikr

    Right, I don't believe it is. I'll open an issue.

  8. locked as resolved and limited conversation to collaborators on Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions