Skip to content

Revert conda run work #9490

Closed
Closed
Revert conda run work#9490
Assignees
kimadeline
Labels
area-environmentsFeatures relating to handling interpreter environmentsbugIssue identified by VS Code Team member as probable bug
Milestone
2019 December Sprint 1

Description

@kimadeline
Kim-Adeline Miguel (kimadeline)
opened on Jan 9, 2020

Issues that were originally closed by the conda run work:

PRs impacted:

💡 Suggestion from Don Jayamanne (@DonJayamanne):

Instead of reverting everything, simply turn it off:

  • modify createCondaExecutionService to return the same value as createActivatedEnvironment.
  • update CondaExecutionService to remove the overridden getExecutionInfo

Activity

  1. Kim-Adeline Miguel (kimadeline)
    added
    bugIssue identified by VS Code Team member as probable bug
    needs PR
    P0
    reason-new feature
    area-environmentsFeatures relating to handling interpreter environments
    in progress
    on Jan 9, 2020
  2. Kim-Adeline Miguel (kimadeline)
    added this to the 2019 December Sprint 2 milestone on Jan 9, 2020
  3. Kim-Adeline Miguel (kimadeline)
    self-assigned this
    on Jan 9, 2020
  4. Kim-Adeline Miguel (kimadeline)
    modified the milestones: 2019 December Sprint 2, 2019 December Sprint 1 on Jan 9, 2020

  5. astrowonk commented on Jan 9, 2020

    @astrowonk
    Marcos Huerta (astrowonk)
    on Jan 9, 2020

    I think this would resolve what I wrote up in #9484.

  6. Kim-Adeline Miguel (kimadeline)
    added
    unplanned
    in review
    and removed
    in progress
    in review
    on Jan 9, 2020

  7. kimadeline commented on Jan 14, 2020

    @kimadeline
    Kim-Adeline Miguel (kimadeline)
    on Jan 14, 2020
    Author

    Fixed in 2020.1.58038, see #9481 (comment)

  8. Kim-Adeline Miguel (kimadeline)
    closed this as completedon Jan 14, 2020
  9. ghost removed
    needs PR
    on Jan 14, 2020
  10. lock
    locked as resolved and limited conversation to collaborators on Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-environmentsFeatures relating to handling interpreter environmentsbugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions