Make "run all tests" icon gray instead of green #9402

Activity

1. ghost added

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Jan 6, 2020
2. Luciana Abud (luabud)

   added

   area-testing

   needs decision

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   on Jan 6, 2020
3. ghost removed

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Jan 6, 2020
4. Luciana Abud (luabud)

   added

   needs PR

   and removed

   needs decision

   on Feb 12, 2020
5. luabud commented on Feb 12, 2020

   

   Luciana Abud (luabud)

   on Feb 12, 2020

   MemberAuthor

   More actions

   @misolori I was talking to the team about this and we had some discussions about this part:

   users who are used to the green play button would expect the debugger.

   Now that VS Code is switching to "Run and Debug" wording instead of "Debug", do you think the green colour in the play icon will still convey debugging? We haven't had issues with users expecting the green icons to start a debug session yet.
6. miguelsolorio commented on Feb 13, 2020

   

   Miguel Solorio (miguelsolorio)

   on Feb 13, 2020

   More actions

   We have been intentional in making our play buttons gray except for debugging, like:

   npm explorer
   

   running extensions
   

   Even though Python users don't use debugging they likely won't get confused, unless they use other languages and use debugging. I think for the sake of consistency we'd like for all of the play buttons to be the same.
7. Karthik Nadig (karthiknadig)

   added

   verifiedVerification succeededVerification succeeded

   on Jul 29, 2021
8. Karthik Nadig (karthiknadig)

   self-assigned this

   on Jul 29, 2021
9. karthiknadig commented on Jul 29, 2021

   

   Karthik Nadig (karthiknadig)

   on Jul 29, 2021

   Member

   More actions

   Fixed via #16769

   
10. Karthik Nadig (karthiknadig)

    added this to the August 2021 milestone on Aug 5, 2021
11. Karthik Nadig (karthiknadig)

    closed this as completedin #16769on Aug 5, 2021
12. github-actions

    locked as resolved and limited conversation to collaborators on Sep 15, 2021