Repository navigation
Improvements to IEnvironmentActivationService to use hidden terminals #2614
Description
Activity
I think this could even skip the terminal altogether, and just spawn the activation script directly (all it needs is to ensure that it runs under the same shell that the actual terminal will be).
I think this could even skip the terminal altogether, and just spawn the activation script directly (all it needs is to ensure that it runs under the same shell that the actual terminal will be).
Agreed. But using the terminal is easier as we don't need to worry about finding paths to shells.
The activation scripts will run in the exact same environment that would other wise run when users run their code. We also have the added advantage of displaying theshellfor diagnostic purposes if something goes wrong.Also this ensures startup scripts are correctly loaded in the shells (something conda requires and initializes when using
conda init).On a side note, a tty interface is required by either
pipenvorpyenv. Can't remember which one it was.I believe this is working. At least it does for me. Ian Huff (@IanMatthewHuff) didn't you say you had a problem with activation with a new environment?
Rich Chiodo (@rchiodo) no. My issue was different, I'm pretty sure, my issue was with our saving of the last successful jupyter environment I think.
Thanks. Validated then.
- locked as resolved and limited conversation to collaborators
on Feb 10, 2020 - unlocked this conversation
on Nov 14, 2020 - locked as resolved and limited conversation to collaborators
on May 7, 2021
Today we use
IEnvironmentActivationServiceto generate environment variables for activated environments. E.g. when running python code on behalf of user as a background process.We do this today by activating the environment and capturing the environment variables.
For this we get the activation commands (using a default shell) and run it as a process.
A better approach is:
Solves
Discussed with Karthik Nadig (@karthiknadig) (helps DAP) Pavel Minaev (@int19h) /cc
FYI - I have started some work on this.