You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #7915 we factored out a helper class for managing virtual envs during testing (see Venvs in src/test/interpreters/locators/workspaceVirtualEnvService.test.ts). As part of that, we addressed an issue with creating a "venv" on Ubuntu using a system python. That included downloading get-pip.py as necessary.
Unfortunately we downloaded that file to a location inside the projects source tree, so git status shows it (as an unmanaged file). This is mildly problematic as we don't want to accidentally commit the file into the repo. In #8902 we added an entry to .gitignore for src/test/get-pip.py, as a temporary solution. We need a permanent solution.
This issue is about a copy of get-pip.py that gets downloaded when certain extension tests are run. The only relationship it has to that other get-pip.py (which the data science team added to the repo and then removed) is the first option above, which is now no longer an option.
This doesn't happen anymore, there are only 2 references to get-pip.py in the code, and they point to pythonFiles/get-pip.py, where the file already exists.
Activity
luabud commentedon May 13, 2020
The file is now gone.
ericsnowcurrently commentedon May 14, 2020
This issue is about a copy of
get-pip.pythat gets downloaded when certain extension tests are run. The only relationship it has to that otherget-pip.py(which the data science team added to the repo and then removed) is the first option above, which is now no longer an option.kimadeline commentedon Feb 1, 2022
This doesn't happen anymore, there are only 2 references to
get-pip.pyin the code, and they point topythonFiles/get-pip.py, where the file already exists.