Skip to content

Fix location for get-pip.py used in tests. #8925

Closed

Description

In #7915 we factored out a helper class for managing virtual envs during testing (see Venvs in src/test/interpreters/locators/workspaceVirtualEnvService.test.ts). As part of that, we addressed an issue with creating a "venv" on Ubuntu using a system python. That included downloading get-pip.py as necessary.

Unfortunately we downloaded that file to a location inside the projects source tree, so git status shows it (as an unmanaged file). This is mildly problematic as we don't want to accidentally commit the file into the repo. In #8902 we added an entry to .gitignore for src/test/get-pip.py, as a temporary solution. We need a permanent solution.

Options:

  1. use an existing vendored copy at ./data/get-pip.py (added in #Fix problem with other kernels that use python being picked. #5628)
  2. vendor a second copy of get-pip.py into the repo (in a better location)
  3. download get-pip.py into a directory in the repo that is ignored in .gitignore
  4. download get-pip.py into a non-temp directory outside the repo
  5. download get-pip.py into temp directory (outside the repo)

Tasks:

  • settle on a permanent solution
  • implement it
  • remove that .gitignore entry

Activity

  1. luabud commented on May 13, 2020

    @luabud
    Member

    The file is now gone.

  2. ericsnowcurrently commented on May 14, 2020

    @ericsnowcurrently
    Author

    This issue is about a copy of get-pip.py that gets downloaded when certain extension tests are run. The only relationship it has to that other get-pip.py (which the data science team added to the repo and then removed) is the first option above, which is now no longer an option.

  3. ghost added
    triage-neededNeeds assignment to the proper sub-team
    on May 14, 2020
  4. kimadeline commented on Feb 1, 2022

    @kimadeline

    This doesn't happen anymore, there are only 2 references to get-pip.py in the code, and they point to pythonFiles/get-pip.py, where the file already exists.

  5. locked as resolved and limited conversation to collaborators on Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-internalLabel for non-user facing issuesdebtCode quality issues

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions