CI is failing due to IFileSystem not being added into IoC container

Karthik Nadig (@karthiknadig)

Eric Snow (@ericsnowcurrently)

Eric Snow (@ericsnowcurrently) This looks like a missed test update. We probably have to add IFileSystem to the envVars.test.ts, it should address the issue?

This should be fixed with the following diff:

diff --git a/src/test/debugger/envVars.test.ts b/src/test/debugger/envVars.test.ts
index 95fc1160..2e2af579 100644
--- a/src/test/debugger/envVars.test.ts
+++ b/src/test/debugger/envVars.test.ts
@@ -49,6 +49,7 @@ suite('Resolving Environment Variables when Debugging', () => {
     function initializeDI() {
         ioc = new UnitTestIocContainer();
         ioc.registerProcessTypes();
+        ioc.registerFileSystemTypes();
         ioc.registerVariableTypes();
         ioc.registerMockProcess();
     }

Make sure IFileSystem is registered in DI during tests. (#8902)

For validation we just need to be sure CI isn't failing for this any more.

Eric Snow (@ericsnowcurrently)

Eric Snow (@ericsnowcurrently) The issue is back in the latest master

Probably from #8993

Submitted a PR to address this

Navigation Menu

Repository navigation

CI is failing due to IFileSystem not being added into IoC container #8882

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

CI is failing due to IFileSystem not being added into IoC container #8882

Description

Activity

karthiknadig commented on Dec 3, 2019

ericsnowcurrently commented on Dec 4, 2019

ericsnowcurrently commented on Dec 5, 2019

DonJayamanne commented on Dec 18, 2019

kimadeline commented on Dec 18, 2019

DonJayamanne commented on Dec 18, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions