Skip to content

Restore skipped venv tests. #8826

Closed
Closed

Description

For #8804 we skipped some of the tests related to venv discovery (see #8810). These tests need to be re-enabled and fixed.

"Interpreters - Workspace VirtualEnv Service"

Activity

  1. ericsnowcurrently commented on Nov 27, 2019

    @ericsnowcurrently
    Author

    Luciana Abud (@luabud)

    I'm pretty sure these were already failing sporadically (checked against master before any of my changes). So fixing this isn't so critical. We could punt it back out of the sprint...

  2. DonJayamanne commented on Dec 4, 2019

    @DonJayamanne

    (checked against master before any of my

    Not sure about this, as it would have caused insiders builds to not get created before FS changes, but thats not true.
    The root cause is the IFileSystem is returning false even when a file exists.

    Basically conda and venv environments do not work at all anymore.
    I'd consider this a P0 and restoring the venv tests.

    Luciana Abud (@luabud) Karthik Nadig (@karthiknadig) /cc

  3. DonJayamanne commented on Dec 4, 2019

    @DonJayamanne

    Cause #8890

  4. ericsnowcurrently commented on Dec 4, 2019

    @ericsnowcurrently
    Author

    FYI, with the fix for #8890 these tests still fail (timing out).

  5. locked as resolved and limited conversation to collaborators on Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    debtCode quality issues

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions