Skip to content

Drop compatibility aliases. #8542

Closed as not planned
Closed as not planned

Description

(depends on PR #7915)

In #7915 I moved some things (related to fs paths) around. To avoid churn, I added some aliases. Those aliases need to be dropped and the churn incurred.

  • simply delete src/client/common/platform/pathUtils.ts
  • in src/client/common/types.ts, remove the IPathUtils and IsWindows exports

Activity

  1. ghost removed on Dec 8, 2020
  2. ghost added
    triage-neededNeeds assignment to the proper sub-team
    on Dec 8, 2020
  3. cpinamtz commented on Jul 4, 2022

    @cpinamtz

    Hi, I'm stuck since the last weeks with this issue trying to compile and install successfully the extension. I began doing the substitution in launchers but I got some errors once I installed the extension.

    Extension activation failed, run the 'Developer: Toggle Developer Tools' command for more information.
    

    I also added the @injectable decorator and the Singleton statement in, I guess, the proper file, but, after compiling and installing the extension it throws in the Python console the following (compiled in webpack development mode to avoid classes renaming):

    [ERROR 2022-6-4 9:23:2.116]: extension activation failed [Error: Missing required @inject or @multiInject annotation in: argument 0 in class FileSystemPathUtils.
    	at getConstructorArgsAsTarget (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53994:19)
    	at getConstructorArgsAsTargets (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:54006:22)
    	at getTargets (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53972:30)
    	at Object.getDependencies (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53957:19)
    	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53838:51
    	at Array.forEach (<anonymous>)
    	at _createSubRequests (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53826:20)
    	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53847:17
    	at Array.forEach (<anonymous>)
    	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53846:26
    	at Array.forEach (<anonymous>)
    	at _createSubRequests (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53826:20)
    	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53847:17
    	at Array.forEach (<anonymous>)
    	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53846:26
    	at Array.forEach (<anonymous>)
    	at _createSubRequests (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53826:20)
    	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53847:17
    	at Array.forEach (<anonymous>)
    	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53846:26
    	at Array.forEach (<anonymous>)
    	at _createSubRequests (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53826:20)
    	at Object.plan (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53868:9)
    	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53390:37
    	at Container.__webpack_modules__../node_modules/inversify/lib/container/container.js.Container._get (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53383:44)
    	at Container.__webpack_modules__../node_modules/inversify/lib/container/container.js.Container.getAll (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53312:21)
    	at ServiceContainer.getAll (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:21761:30)
    	at activateLegacy (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:18585:18)
    	at processTicksAndRejections (node:internal/process/task_queues:96:5)
    	at async activateComponents (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:18514:36)
    	at async activateUnsafe (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:114915:33)
    	at async activate (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:114884:42)
    	at async _activate (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:83:8180)
    	at async _waitForDepsThenActivate (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:83:8122)
    	at async _initialize (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:83:7486)]
    

    I'm sure I'm missing something really simple but I don't know what. Thanks in advance

  4. karrtikr commented on Dec 22, 2022

    @karrtikr

    This class is used in a lot of places now.

  5. locked as resolved and limited conversation to collaborators on Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-internalLabel for non-user facing issuesdebtCode quality issuesneeds PRReady to be worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions