Repository navigation
Make sure tests generated by pytest plugins are not ignored. #8425
Description
Need to improve handling pytest-plugins tests, because after resolving #7287 they are skipped.
[added by Eric Snow (@ericsnowcurrently)]:
Just to be clear, this is about pytest plugins that add in extra test nodes/items during the "collection" phase. By default pytest collects tests/suites/modules/packages on the filesystem (and optionally doctests). This is what the testing adapter script is focused on accommodating.
Additionally, pytest allows plugins to add test nodes (e.g. the pep8 plugin). However, the adapter doesn't know how to handle those. In #8242 we start ignoring them instead of failing. That isn't ideal, so we should work on supporting plugin-generated test nodes.
FWIW, I am not sure what the old code (parsing the pytest CLI output) used to do with plugin-generated nodes. My vague recollection is that it ignored them as well (but that should probably be verified). That is the reason this is an enhancement request.
Activity
zztalker commentedon Nov 7, 2019
Eric Snow (@ericsnowcurrently) please, take a look.
ericsnowcurrently commentedon Nov 7, 2019
Thanks for opening this issue, Pavel Zaikin (@zztalker). Did I understand correctly from PR #8242 that you are going to work on a separate PR for this. If so, go for it! :) In the meantime we'll take a look as soon as we can.
Luciana Abud (@luabud)
pytest: Tests: Derive from `pytest.Function` rather than `Item`
pytest: Tests: Derive from `pytest.Function` rather than `Item`
eleanorjboyd commentedon Oct 30, 2023
Hello! We have just finished our testing rewrite and are beginning the roll out to users. If you are able, it would be very helpful to know if your issue still exists on the rewrite! To use the rewrite yourself just add
”python.experiments.optInto": ["pythonTestAdapter"]to your user settings. You can confirm you have the rewrite enabled by setting your log level to trace, via theDeveloper: Set Log Levelcommand in the command palette. Then check to see ifExperiment 'pythonTestAdapter' is activeis in your python logs.Thanks!
svenaron commentedon Nov 16, 2023
Eleanor Boyd (@eleanorjboyd)
I can confirm that the issue is still present, even with pythonTestAdapter enabled.
The tests are shown in the output from the pytest collect call, but not in the test-panel.
eleanorjboyd commentedon Nov 27, 2023
Thank you for taking a look. I will investigate this shortly, thanks!
github-actions commentedon Dec 20, 2023
Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.
eleanorjboyd commentedon Dec 20, 2023
Need community feedback here on if this is still a relevant ask people want for the extension, thanks!
brettcannon commentedon Feb 22, 2024
Thank you for submitting your feature request and everyone who considered it! Unfortunately, this issue did not receive enough votes over the allotted time, and so we are closing the issue.