Skip to content

Use DebugAdapterTracker for logging #8106

Closed
Closed
Use DebugAdapterTracker for logging#8106
Assignees
karthiknadig
Labels
area-debuggingfeature-requestRequest for new features or functionality
Milestone
2019 October Sprint 3

Description

@karthiknadig
Karthik Nadig (karthiknadig)
opened on Oct 18, 2019

When we switch to the thew debug adapter we will loose extension side logging for the DAP. Since it currently sits in the type script debug adapter. We should be using DebugAdapterTracker for logging to ensure we can capture logs in all debug sessions attach or launch.

Activity

  1. Karthik Nadig (karthiknadig)
    added
    feature-requestRequest for new features or functionality
    triage-neededNeeds assignment to the proper sub-team
    area-debugging
    needs PR
    on Oct 18, 2019
  2. ghost removed
    triage-neededNeeds assignment to the proper sub-team
    on Oct 21, 2019
  3. Karthik Nadig (karthiknadig)
    added this to the 2019 October Sprint 3 milestone on Oct 30, 2019
  4. Kim-Adeline Miguel (kimadeline)
    added
    in review
    on Oct 30, 2019
  5. Karthik Nadig (karthiknadig)
    assigned
    Eric Snow (ericsnowcurrently)
    on Oct 31, 2019
  6. Eric Snow (ericsnowcurrently)
    assigned
    Karthik Nadig (karthiknadig)
    on Nov 5, 2019

  7. ericsnowcurrently commented on Nov 5, 2019

    @ericsnowcurrently
    Eric Snow (ericsnowcurrently)
    on Nov 5, 2019

    Karthik Nadig (@karthiknadig), how to validate?

  8. karthiknadig commented on Nov 5, 2019

    @karthiknadig
    Karthik Nadig (karthiknadig)
    on Nov 5, 2019
    MemberAuthor

    Ensure you are in debug adapter descriptor experiment. Ensure ‘logToFile’:true is set in launch json. Then just debug any python script.

  9. karthiknadig commented on Nov 5, 2019

    @karthiknadig
    Karthik Nadig (karthiknadig)
    on Nov 5, 2019
    MemberAuthor

    Oh and the result would be a .log file in the python extension directory.

  10. Eric Snow (ericsnowcurrently)
    removed their assignment
    on Nov 6, 2019

  11. ericsnowcurrently commented on Nov 6, 2019

    @ericsnowcurrently
    Eric Snow (ericsnowcurrently)
    on Nov 6, 2019

    I was able to verify that (on master) the log file (2 actually) is created when I put myself in the experiment and add that setting to my launch config. I also verified that logs are no longer created after I remove that setting.

  12. Eric Snow (ericsnowcurrently)
    closed this as completedon Nov 6, 2019
  13. ghost removed
    needs PR
    on Nov 6, 2019
  14. lock
    locked as resolved and limited conversation to collaborators on Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-debuggingfeature-requestRequest for new features or functionality

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions