Skip to content

Add button to get more info related to inheritEnv setting when prompt is dispalyed #7733

Description

As a user of VS Code I won't know what the setting inheritEnv is.
It would be good to add a button that the user could click to get more information.

Its just like any other prompt, LS does not work and we switch to Jedi, and we add a button where users can get more info about this.
E.g. what is LS and what is .NET core. Same here.

Screen Shot 2019-10-02 at 09 08 34

Activity

  1. karrtikr commented on Oct 2, 2019

    @karrtikr

    We might want to do this quickly because this is only a one-time prompt. We don't want to show this prompt again to the same User with More info button.

  2. DonJayamanne commented on Oct 2, 2019

    @DonJayamanne
    Author

    We might want to do this quickly because this is only a one-time prompt. We don't want to show this prompt again with More info button.

    Doesn't make sense. Personally I dont see any harm in adding the button for the benefit of the user.

    As a user i don't know what inhertiEnv is! I will click no or go open my browser google this, find the right issue/blog that explains this and then come back.
    Now open VS Code and the prompt has gone away!

  3. karrtikr commented on Oct 2, 2019

    @karrtikr

    What I meant was that for the users who already have seen the prompt, we don't want to show the prompt again with More info button.
    So we should get this in for this release so most users see the prompt you suggested (with the the More info button).

  4. ghost removed
    triage-neededNeeds assignment to the proper sub-team
    on Oct 2, 2019
  5. DonJayamanne commented on Oct 2, 2019

    @DonJayamanne
    Author

    we don't want to show the prompt again with More info button.

    I'd always leave it in there.

  6. karthiknadig commented on Oct 9, 2019

    @karthiknadig
    Member

    See #7861 this did not work.

  7. luabud commented on Oct 10, 2019

    @luabud
    Member

    Interesting, it worked for me:
    image

  8. kimadeline commented on Oct 18, 2019

    @kimadeline

    Since it worked for Luciana Abud (@luabud) and Karthik Nadig (@karthiknadig) (see #7607 (comment)) I'm gonna mark this issue as ✅ validated ✅ and close it.

  9. locked as resolved and limited conversation to collaborators on Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area-intellisenseLSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc.feature-requestRequest for new features or functionality

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions