Skip to content

Update PythonExecutionService to support "conda run". #7696

Closed
Closed
Update PythonExecutionService to support "conda run".#7696
Assignees
karrtikr
Labels
area-environmentsFeatures relating to handling interpreter environmentsdebtCode quality issues
Milestone
2019 November Sprint 2

Description

@ericsnowcurrently
Eric Snow (ericsnowcurrently)
opened on Sep 30, 2019

This will involve the following:

  • change PythonExecutionService.pythonPath (a string) to PythonExecutionService.pyArgv (an array of strings)
  • update PythonExecutionService.create() to pass an array of strings to PythonExecutionService()
  • update PythonExecutionService.createActivatedEnvironment() to pass an array of strings to PythonExecutionService()
  • verify that the usage in the various places works properly for conda and non-conda:
    • formatting
      • src/client/formatters/baseFormatter.ts (via PythonToolExecutionService)
    • linting
      • src/client/linters/errorHandlers/notInstalled.ts
      • src/client/linters/baseLinter.ts (via PythonToolExecutionService)
    • testing
      • src/client/testing/common/services/discovery.ts
      • src/client/testing/common/runner.ts
      • src/client/testing/common/runner.ts (via PythonToolExecutionService)
    • installers
      • src/client/common/installer/pipInstaller.ts
      • src/client/common/installer/productInstaller.ts
    • debugger
      • src/client/debugger/extension/adapter/factory.ts
    • interpreter discovery
      • src/client/interpreter/locators/services/workspaceVirtualEnvWatcherService.ts
      • src/client/interpreter/configuration/pythonPathUpdaterService.ts
      • src/client/interpreter/helpers.ts
      • src/client/interpreter/interpreterService.ts
      • src/client/interpreter/locators/services/windowsStoreInterpreter.ts
    • import sorting
      • src/client/providers/importSortProvider.ts
    • jedi
      • src/client/providers/jediProxy.ts
    • refactoring
      • src/client/refactor/proxy.ts

Activity

  1. Eric Snow (ericsnowcurrently)
    added
    needs PR
    debtCode quality issues
    feature-interpreter
    on Sep 30, 2019
  2. Karthik Nadig (karthiknadig)
    added this to the 2019 October Sprint 2 milestone on Oct 9, 2019
  3. Graham Wheeler (gramster)
    added
    area-environmentsFeatures relating to handling interpreter environments
    and removed
    feature-interpreter
    on Oct 10, 2019
  4. Kim-Adeline Miguel (kimadeline)
    self-assigned this
    on Oct 21, 2019

  5. kimadeline commented on Oct 23, 2019

    @kimadeline
    Kim-Adeline Miguel (kimadeline)
    on Oct 23, 2019

    Make sure conda run works with both named environment and non-named environment (where we have to use the path)

  6. Karthik Nadig (karthiknadig)
    modified the milestones: 2019 October Sprint 2, 2019 October Sprint 3 on Oct 23, 2019
  7. Graham Wheeler (gramster)
    added
    in progress
    on Oct 29, 2019
  8. Kim-Adeline Miguel (kimadeline)
    added
    in review
    in progress
    and removed
    in progress
    in review
    on Nov 4, 2019
  9. Karthik Nadig (karthiknadig)
    modified the milestones: 2019 October Sprint 3, 2019 November Sprint 1 on Nov 7, 2019
  10. Kim-Adeline Miguel (kimadeline)
    added
    in review
    and removed
    in progress
    on Nov 18, 2019
  11. Eric Snow (ericsnowcurrently)
    modified the milestones: 2019 November Sprint 1, 2019 November Sprint 2 on Nov 20, 2019
  12. Kim-Adeline Miguel (kimadeline)
    removed
    in review
    on Nov 21, 2019

  13. kimadeline commented on Nov 25, 2019

    @kimadeline
    Kim-Adeline Miguel (kimadeline)
    on Nov 25, 2019

    To validate:

    • workspace with a named conda environment (conda create --name yourenv or conda create -n yourenv)
      • extension loads
      • extension selects the workspace correctly
      • formatting should be executed using conda run
      • linting should be executed using conda run
      • run in terminal should be executed using conda run
      • test discovery using pytest should be executed using conda run
    • workspace with a prefixed conda environment (conda create --prefix path/to/env)
      • extension loads
      • extension selects the workspace correctly
      • formatting should be executed using conda run
      • linting should be executed using conda run
      • run in terminal should be executed using conda run
      • test discovery using pytest should be executed using conda run
  14. Kim-Adeline Miguel (kimadeline)
    assigned
    Kartik Raj (karrtikr)
    and unassigned
    Kim-Adeline Miguel (kimadeline)
    on Nov 25, 2019

  15. karrtikr commented on Nov 25, 2019

    @karrtikr
    Kartik Raj (karrtikr)
    on Nov 25, 2019

    validated

  16. Kartik Raj (karrtikr)
    closed this as completedon Nov 25, 2019
  17. ghost removed
    needs PR
    on Nov 25, 2019

  18. karrtikr commented on Nov 25, 2019

    @karrtikr
    Kartik Raj (karrtikr)
    on Nov 25, 2019

    Found an unrelated issue while validating it. #8783

  19. lock
    locked as resolved and limited conversation to collaborators on Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-environmentsFeatures relating to handling interpreter environmentsdebtCode quality issues

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions