Skip to content

Add prompt to flip "inheritEnv" setting to false to fix conda activation issue #7607

Description

@luabud

To address #5764

if it isn't a Windows machine and if the selected interpreter is a conda environment and "terminal.integrated.inheritEnv" is not set on the user's user settings, we can prompt the message below:

"We noticed you're using a conda environment. If you are experiencing issues with this environment in the integrated terminal, we suggest the "terminal.integrated.inheritEnv" setting to be changed to false. Would you like to update this setting?"
Options: Yes, No

And add telemetry for the yes selection, so we can know if this is actually solving the issue.

Activity

  1. ghost removed
    triage-neededNeeds assignment to the proper sub-team
    on Sep 25, 2019
  2. added
    bugIssue identified by VS Code Team member as probable bug
    and removed
    feature-requestRequest for new features or functionality
    on Sep 25, 2019
  3. karthiknadig commented on Sep 25, 2019

    @karthiknadig
    Member

    If the user dismisses (the "X") we should show it again. The context of the setting is User Setting, and should apply to all work spaces.

  4. karthiknadig commented on Oct 5, 2019

    @karthiknadig
    Member

    Looks like inheritEnv is set by default, in user settings. This was from a fresh install of vscode:
    image

  5. luabud commented on Oct 10, 2019

    @luabud
    MemberAuthor

    Just to make sure everyone understands what is the issue, the prompt is being displayed for Windows users (and apparently not for Mac nor Linux) as you can see here: #7861
    Whoever works on this, please can you change the wording to specify that the changes will be on the settings.json file in the prompt, as described in the issue above? i.e. "[...], we suggest the "terminal.integrated.inheritEnv" setting to be changed to false in the settings.json file. [...]"

  6. DonJayamanne commented on Oct 10, 2019

    @DonJayamanne

    setting to be changed to false in the settings.json file

    Can I suggest we change as follows setting to be changed to false in the settings (settings.json file)

    Novice users won't know what settings.json file is. VS Code has change the default settings configuration to a fancy UI and hidden the settings.json file behind the UI.

  7. kylekeppler commented on Oct 17, 2019

    @kylekeppler

    I had to also run conda init powershell in the VS code powershell terminal. After running that once, the correct env is activated in the future when creating powershell terminals in VS code. (Conda 4.7.12, VS Code 1.38.2, Python Ext 2019.10.41019)

  8. karthiknadig commented on Oct 18, 2019

    @karthiknadig
    Member

    Verified on Linux:
    image

  9. kimadeline commented on Oct 18, 2019

    @kimadeline

    Verified on Windows with 2019.11.42782-dev: Nothing appeared when opening a workspace and selecting a conda environment.

    Closing this issue and #7733.

  10. locked as resolved and limited conversation to collaborators on Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area-terminalbugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions