[meta] Use conda run for running tools #7425

Activity

1. Luciana Abud (luabud)

   added

   needs PR

   debtCode quality issuesCode quality issues

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Sep 16, 2019
2. ghost removed

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Sep 16, 2019
3. luabud commented on Sep 16, 2019

   

   Luciana Abud (luabud)

   on Sep 16, 2019

   Last edited by luabud

   MemberAuthor

   More actions

   • changes in PythonExecutionFactory and PythonExecutionService fix the following (Update PythonExecutionService to support "conda run". #7696):
     • formatting
     • linting
     • testing (partial)
     • installers (partial)
     • debugger (partial)
     • interpreter discovery (partial)
     • import sorting (partial)
     • jedi
     • refactoring
     • (datascience?)
   • currently do exec() (Stop using "exec()" in the extension. #7697):
     • testing (partial)
     • installers (partial)
     • debugger (partial)
     • interpreter discovery (partial)
     • import sorting (partial)
     • code execution / terminal
     • (datascience?)
   • currently do spawn():
     • [ ] old debug adapter (launch)
   • ensure that (at this point) the extension only uses PythonExecutionFactory for running python
   • [ ] old debug adapter (multi-proc case) Use conda run in the debug adapter #6010
   • verify if fixes issue with Jupyter (Jupyter doesn't work with anaconda #5539)
4. Luciana Abud (luabud)

   added

   feature-*

   on Sep 16, 2019
5. Luciana Abud (luabud)

   changed the title [-]Use conda run for running tools[/-] [+]Use `conda run` for running tools[/+] on Sep 16, 2019
6. Brett Cannon (brettcannon)

   added this to the 2019 - September Sprint 2 milestone on Sep 16, 2019
7. DonJayamanne commented on Sep 17, 2019

   

   Don Jayamanne (DonJayamanne)

   on Sep 17, 2019

   More actions

   Isn't this a duplicate of #6010?
8. luabud commented on Sep 17, 2019

   

   Luciana Abud (luabud)

   on Sep 17, 2019

   MemberAuthor

   More actions

   Don Jayamanne (@DonJayamanne) we separated the issues for running tools and for the debugger
9. DonJayamanne commented on Sep 17, 2019

   

   Don Jayamanne (DonJayamanne)

   on Sep 17, 2019

   Last edited by DonJayamanne

   More actions

   Added another item for running Jupyter (DataScience)
10. DonJayamanne commented on Sep 17, 2019

    

    Don Jayamanne (DonJayamanne)

    on Sep 17, 2019

    More actions

    Luciana Abud (@luabud) Brett Cannon (@brettcannon)
    I'd prefer to somehow implement this as an experiment.
    I.e. roll this out slowly to users, rather than everyone in one go. This way we'll know whether it works or not. If it doesn't work or we have issues, then the number of users impacted is small.
11. brettcannon commented on Sep 18, 2019

    

    Brett Cannon (brettcannon)

    on Sep 18, 2019

    Member

    More actions

    Don Jayamanne (@DonJayamanne) how is this not going to be an improvement from what we are doing now? conda run is the official way to do this sort of thing now, so I'm not seeing where the worry is about it being "wrong".
12. DonJayamanne commented on Sep 19, 2019

    

    Don Jayamanne (DonJayamanne)

    on Sep 19, 2019

    Last edited by DonJayamanne

    More actions

    I'm not seeing where the worry is about it being "wrong".

    Just a fear of something going wrong. Nothing else. 😁
13. karrtikr commented on Sep 25, 2019

    

    Kartik Raj (karrtikr)

    on Sep 25, 2019

    More actions

    Meta issue

    • Looks like formatting, linting, and testing are run from one place in the extension
      https://github.com/Microsoft/vscode-python/blob/ecad0ce4df2b5a3da299c5f7775c8735305b846c/src/client/common/process/pythonExecutionFactory.ts

    • Code execution is run separately

    • Jupyter (Jupyter doesn't work with anaconda #5539)

    • discovery of interpreter environments? (see Unable to access Python 3 environments in /anaconda2 #7548)
14. Kartik Raj (karrtikr)

    added

    metaIssue that is tracking an overall projectIssue that is tracking an overall project

    on Sep 25, 2019
15. Eric Snow (ericsnowcurrently)

    changed the title [-]Use `conda run` for running tools[/-] [+][meta] Use `conda run` for running tools[/+] on Sep 25, 2019
16. ericsnowcurrently commented on Sep 30, 2019

    

    Eric Snow (ericsnowcurrently)

    on Sep 30, 2019

    More actions

    There is also a concern that "pythonPath" in debug config (see #7690) can conflict and cause a problem.
17. Luciana Abud (luabud)

    added

    importantIssue identified as high-priorityIssue identified as high-priority

    on Oct 8, 2019
18. luabud commented on Oct 9, 2019

    

    Luciana Abud (luabud)

    on Oct 9, 2019

    MemberAuthor

    More actions

    Closing in favour of #5344.
19. Luciana Abud (luabud)

    closed this as completedon Oct 9, 2019
20. ghost removed

    needs PR

    on Oct 9, 2019
21. lock

    locked as resolved and limited conversation to collaborators on Oct 16, 2019