Repository navigation
editing python after inline if statement invalid indent #726
Description
- VSCode Version: Code 1.19.3 (7c4205b5c6e52a53b81c69d2b2dc8a627abaa0ba, 2018-01-25T10:32:23.601Z)
- OS Version: Linux x64 4.4.0-112-generic
- Extensions:
| Extension | Author (truncated) | Version |
|---|---|---|
| bracket-pair-colorizer | Coe | 0.10.14 |
| vscode-markdownlint | Dav | 0.13.0 |
| xml | Dot | 1.9.2 |
| beautify | Hoo | 1.3.0 |
| code-settings-sync | Sha | 2.8.7 |
| Bookmarks | ale | 0.18.1 |
| code-gnu-global | aus | 0.2.2 |
| line-counter | dol | 0.3.0 |
| php-debug | fel | 1.12.1 |
| phpcs | ika | 0.7.0 |
| svn-scm | joh | 1.15.0 |
| sublime-babel-vscode | jos | 0.2.9 |
| python | ms- | 2018.1.0 |
| cpptools | ms- | 0.14.6 |
| csharp | ms- | 1.13.1 |
| mono-debug | ms- | 0.15.8 |
| debugger-for-chrome | msj | 4.1.0 |
| vscode-icons | rob | 7.19.0 |
| trailing-spaces | sha | 0.2.11 |
| vscode-hexdump | sle | 1.6.0 |
| tom | 0.2.0 | |
| change-case | wma | 1.0.0 |
| markdown-pdf | yza | 0.1.7 |
(3 theme extensions excluded)
Steps to Reproduce:
- open any python file (any.py)
- write an if statement with true part in the same line (if True: a=1)
- press enter. the indent raises one level - it should not
Reproduces without extensions: N/A
turning off extensions turns off also python highlighting
Activity
elliott-beach commentedon Feb 8, 2018
Can confirm.
MikhailArkhipov commentedon Feb 20, 2018
Currently indentation analysis is based on vscode (regex rules) rather than actual AST analysis so it is a bit simple
https://github.com/Microsoft/vscode-python/blob/master/src/client/extension.ts#L129-L146
Fix indentation on single-liners and f-strings in type formatting (#1312
Fix handling of escaped string in tokenizer + PTVS launch hardening (#…
Add telemetry reporting on VS analysis engine usage (#1382)
Jedi 0.12 (#1418)
Replace unzip package (#1419)
Fixes multiple issues with formatting on type (#1450)
Improve detection of the function argument list in autoformat (#1508)
PTVS engine update + handling of the interpreter change (#1613)
Changes to IntelliCode and engine downloads (#1715)
Fix bug, remove unnecessary flag, fix hash comparison on Linux (#1734)
Simplifies LS startup and update test baselines (#1762)
Rename engine to 'Microsoft Python Language Server' (#1768)
Format on type fixes (#1798)
Handle numbers formatted with underscores in tokenizer (#1819)
Improve detection if '=' is in function or lambda arguments (#1824)
Add command for loading of LS extensions (#1914)